Rocksolid Light

Welcome to RetroBBS

mail  files  register  newsreader  groups  login

Message-ID:  

Clothes make the man. Naked people have little or no influence on society. -- Mark Twain


devel / comp.protocols.dicom / Part15 inconsistencies with attribute types

SubjectAuthor
* Part15 inconsistencies with attribute typesMathieu Malaterre
`* Re: Part15 inconsistencies with attribute typesDavid Clunie
 `- Re: Part15 inconsistencies with attribute typesMathieu Malaterre

1
Part15 inconsistencies with attribute types

<247ae4ed-79f2-4f33-ad1b-48325eccd1a2n@googlegroups.com>

  copy mid

https://www.rocksolidbbs.com/devel/article-flat.php?id=764&group=comp.protocols.dicom#764

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:a05:6214:ab2:b0:635:db54:4885 with SMTP id ew18-20020a0562140ab200b00635db544885mr69826qvb.4.1688997636785;
Mon, 10 Jul 2023 07:00:36 -0700 (PDT)
X-Received: by 2002:a63:7e55:0:b0:553:ec49:f310 with SMTP id
o21-20020a637e55000000b00553ec49f310mr8558342pgn.3.1688997636045; Mon, 10 Jul
2023 07:00:36 -0700 (PDT)
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!1.us.feeder.erje.net!feeder.erje.net!usenet.blueworldhosting.com!diablo1.usenet.blueworldhosting.com!peer03.iad!feed-me.highwinds-media.com!news.highwinds-media.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Mon, 10 Jul 2023 07:00:35 -0700 (PDT)
Injection-Info: google-groups.googlegroups.com; posting-host=91.173.12.104; posting-account=5syELgoAAABMLWsjbxhk8Wo7CLxGgTPG
NNTP-Posting-Host: 91.173.12.104
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <247ae4ed-79f2-4f33-ad1b-48325eccd1a2n@googlegroups.com>
Subject: Part15 inconsistencies with attribute types
From: mathieu.malaterre@gmail.com (Mathieu Malaterre)
Injection-Date: Mon, 10 Jul 2023 14:00:36 +0000
Content-Type: text/plain; charset="UTF-8"
X-Received-Bytes: 2596
 by: Mathieu Malaterre - Mon, 10 Jul 2023 14:00 UTC

Hi all,

I am having a hard time understanding the Part15/Table E.1-1. Application Level Confidentiality Profile Attributes.

I was under the impression there would be an equivalence in between:

De-identification Action Codes D <=> Type 1
De-identification Action Codes Z <=> Type 2
De-identification Action Codes X <=> Type 3

This does not appear to be true for the following case:

Consider "Magnetic Resonance Image IOD", which points to:
* https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_A.4.3.html
Which points to:
* https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.html#sect_C.7.1.1
Which points to:
* https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.7.html#table_C.7.1.4-1

In other word, the first PatientID attribute is Type 2, while the second one is Type 1 in the following:

[...]
(0010,0020) LO [FOO] # 4, 1 PatientID
(0010,0026) SQ (Sequence with explicit length #=2) # 40, 1 SourcePatientGroupIdentificationSequence
(fffe,e000) na (Item with explicit length #=1) # 12, 1 Item
(0010,0020) LO [BAR] # 4, 1 PatientID
[...]

However now looking at part15:
* https://dicom.nema.org/medical/dicom/current/output/chtml/part15/chapter_E.html#table_E.1-1

All I can see is a 'Z' only:

[...]
Patient ID (0010,0020) N Y Z
[...]

Did I misinterpret the Part15 section, or is this just a typo and the line should read De-identification Action Codes 'Z/D' in this case ?

Thanks

Re: Part15 inconsistencies with attribute types

<00bc8881-392b-44ca-816a-f3e1b80f695bn@googlegroups.com>

  copy mid

https://www.rocksolidbbs.com/devel/article-flat.php?id=768&group=comp.protocols.dicom#768

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:a05:6214:1774:b0:635:e19a:6cc4 with SMTP id et20-20020a056214177400b00635e19a6cc4mr100588qvb.2.1689075023872;
Tue, 11 Jul 2023 04:30:23 -0700 (PDT)
X-Received: by 2002:aca:e1c4:0:b0:3a3:6881:242 with SMTP id
y187-20020acae1c4000000b003a368810242mr1185738oig.11.1689075023474; Tue, 11
Jul 2023 04:30:23 -0700 (PDT)
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!diablo1.usenet.blueworldhosting.com!peer01.iad!feed-me.highwinds-media.com!news.highwinds-media.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Tue, 11 Jul 2023 04:30:23 -0700 (PDT)
In-Reply-To: <247ae4ed-79f2-4f33-ad1b-48325eccd1a2n@googlegroups.com>
Injection-Info: google-groups.googlegroups.com; posting-host=50.32.234.71; posting-account=rKkGZwkAAADOuxQ23uuHnmKt95j-5iL6
NNTP-Posting-Host: 50.32.234.71
References: <247ae4ed-79f2-4f33-ad1b-48325eccd1a2n@googlegroups.com>
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <00bc8881-392b-44ca-816a-f3e1b80f695bn@googlegroups.com>
Subject: Re: Part15 inconsistencies with attribute types
From: dclunie@dclunie.com (David Clunie)
Injection-Date: Tue, 11 Jul 2023 11:30:23 +0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Received-Bytes: 3413
 by: David Clunie - Tue, 11 Jul 2023 11:30 UTC

When we introduced the Patient Group Macro to handle multiple small animals being imaged at the same time, I don't think it occurred to us that de-identification was relevant, so the PS3.15 profile was not considered.

Strictly speaking, it would be appropriate to amend the action code as you describe, since Patient ID is Type 1 within the sequences of the Patient Group Macro.

I will submit a CP.

David

On Monday, July 10, 2023 at 10:00:38 AM UTC-4, Mathieu Malaterre wrote:
> Hi all,
>
> I am having a hard time understanding the Part15/Table E.1-1. Application Level Confidentiality Profile Attributes.
>
> I was under the impression there would be an equivalence in between:
>
> De-identification Action Codes D <=> Type 1
> De-identification Action Codes Z <=> Type 2
> De-identification Action Codes X <=> Type 3
>
> This does not appear to be true for the following case:
>
> Consider "Magnetic Resonance Image IOD", which points to:
> * https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_A..4.3.html
> Which points to:
> * https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C..7.html#sect_C.7.1.1
> Which points to:
> * https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C..7.html#table_C.7.1.4-1
>
> In other word, the first PatientID attribute is Type 2, while the second one is Type 1 in the following:
>
> [...]
> (0010,0020) LO [FOO] # 4, 1 PatientID
> (0010,0026) SQ (Sequence with explicit length #=2) # 40, 1 SourcePatientGroupIdentificationSequence
> (fffe,e000) na (Item with explicit length #=1) # 12, 1 Item
> (0010,0020) LO [BAR] # 4, 1 PatientID
> [...]
>
> However now looking at part15:
> * https://dicom.nema.org/medical/dicom/current/output/chtml/part15/chapter_E.html#table_E.1-1
>
> All I can see is a 'Z' only:
>
> [...]
> Patient ID (0010,0020) N Y Z
> [...]
>
> Did I misinterpret the Part15 section, or is this just a typo and the line should read De-identification Action Codes 'Z/D' in this case ?
>
> Thanks

Re: Part15 inconsistencies with attribute types

<27cff670-ea51-4203-8ce9-c51f0062a0c9n@googlegroups.com>

  copy mid

https://www.rocksolidbbs.com/devel/article-flat.php?id=769&group=comp.protocols.dicom#769

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:ad4:5985:0:b0:635:93ec:4d8a with SMTP id ek5-20020ad45985000000b0063593ec4d8amr63618qvb.10.1689082168283;
Tue, 11 Jul 2023 06:29:28 -0700 (PDT)
X-Received: by 2002:a05:6870:98ae:b0:1b0:41da:daa8 with SMTP id
eg46-20020a05687098ae00b001b041dadaa8mr1949135oab.1.1689082168057; Tue, 11
Jul 2023 06:29:28 -0700 (PDT)
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!diablo1.usenet.blueworldhosting.com!peer02.iad!feed-me.highwinds-media.com!news.highwinds-media.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Tue, 11 Jul 2023 06:29:27 -0700 (PDT)
In-Reply-To: <00bc8881-392b-44ca-816a-f3e1b80f695bn@googlegroups.com>
Injection-Info: google-groups.googlegroups.com; posting-host=91.173.12.104; posting-account=5syELgoAAABMLWsjbxhk8Wo7CLxGgTPG
NNTP-Posting-Host: 91.173.12.104
References: <247ae4ed-79f2-4f33-ad1b-48325eccd1a2n@googlegroups.com> <00bc8881-392b-44ca-816a-f3e1b80f695bn@googlegroups.com>
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <27cff670-ea51-4203-8ce9-c51f0062a0c9n@googlegroups.com>
Subject: Re: Part15 inconsistencies with attribute types
From: mathieu.malaterre@gmail.com (Mathieu Malaterre)
Injection-Date: Tue, 11 Jul 2023 13:29:28 +0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Received-Bytes: 3368
 by: Mathieu Malaterre - Tue, 11 Jul 2023 13:29 UTC

On Tuesday, July 11, 2023 at 1:30:25 PM UTC+2, David Clunie wrote:
> When we introduced the Patient Group Macro to handle multiple small animals being imaged at the same time, I don't think it occurred to us that de-identification was relevant, so the PS3.15 profile was not considered.
>
> Strictly speaking, it would be appropriate to amend the action code as you describe, since Patient ID is Type 1 within the sequences of the Patient Group Macro.
>
> I will submit a CP.

Honestly this was not the answer I was expected :(

Instead something more like this:

---

Hi Mathieu !

Thanks for bringing this back to our attention. You are indeed right Part15 / Attribute Confidentiality Profiles is a bit over-engineered. When Supp 142 was introduced, we thought having multiple action codes for fine tuning ('D' vs 'Z' vs 'X') would make sense for implementers and would help wide spread adoption.

It turns out to be a massive burden to maintain this table as existing attributes are added with different Type as initially planned in Supp 142.

Since we lost the original script to automatically update this table, we are planning to replace all action codes D/Z/X/U combinations with simply two: "X/Z/D" and "X/Z/U*". This should perfectly handle any update of the standard and can be "burned in" any implementation and be future proof while backward compatible.

As a side note you should have already noticed multiple typos like the one you reported, for instance:

* "0008,009C" is not 'Z' but 'X',
* "0008,0050" is not 'Z' but 'X/Z',
* "0400,0550" is not 'X' but 'XD',
* "0400,0552" is not 'X' but 'XD',
* "0040,1001" is not 'X' but 'XD',
* "0010,2299" is not 'X' but 'Z',
* "0010,2297" is not 'X' but 'Z',
* "0040,0009" is not 'X' but XD,
* "0018,1009" is not 'X' but XD,
* so many more but the margin is too small to contain them

Since it does not make much sense to constantly update this table as a favor to implementers, we are planning to globally simplify this table.

Regards
--
Anonymous

1
server_pubkey.txt

rocksolid light 0.9.8
clearnet tor