Rocksolid Light

Welcome to RetroBBS

mail  files  register  newsreader  groups  login

Message-ID:  

Nondeterminism means never having to say you are wrong.


devel / comp.protocols.dicom / MWL - Return Key Attributes of Type 1

SubjectAuthor
* MWL - Return Key Attributes of Type 1madMorty
`* Re: MWL - Return Key Attributes of Type 1Thomas Freier
 `- Re: MWL - Return Key Attributes of Type 1madMorty

1
MWL - Return Key Attributes of Type 1

<f772ebb7-7c9c-4357-ad13-3dea60a50f72n@googlegroups.com>

  copy mid

https://www.rocksolidbbs.com/devel/article-flat.php?id=286&group=comp.protocols.dicom#286

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:ad4:5b82:: with SMTP id 2mr30495374qvp.22.1642665559856;
Wed, 19 Jan 2022 23:59:19 -0800 (PST)
X-Received: by 2002:a37:9e96:: with SMTP id h144mr17179527qke.250.1642665559660;
Wed, 19 Jan 2022 23:59:19 -0800 (PST)
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!news.misty.com!border2.nntp.dca1.giganews.com!nntp.giganews.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Wed, 19 Jan 2022 23:59:19 -0800 (PST)
Injection-Info: google-groups.googlegroups.com; posting-host=2003:d7:ff1c:1100:c272:aa1f:74b9:96ae;
posting-account=JEyPZwoAAADgvqXlfDn3_bdujWVbq4jy
NNTP-Posting-Host: 2003:d7:ff1c:1100:c272:aa1f:74b9:96ae
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <f772ebb7-7c9c-4357-ad13-3dea60a50f72n@googlegroups.com>
Subject: MWL - Return Key Attributes of Type 1
From: madmortyonthehunt@gmail.com (madMorty)
Injection-Date: Thu, 20 Jan 2022 07:59:19 +0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Lines: 35
 by: madMorty - Thu, 20 Jan 2022 07:59 UTC

Hi,

at the moment I am currently workling on an MWL SCU and have some questions regarding proper interpretation/handling of the Matching Key Type (optional/required) and the Return Key Types. Maybe someone of you finds time to discuss the following questions a bit further with me:

1. From my understanding the SCP will/should only ever return attributes within its MWL responses that where originally part of the SCU identifier within its C-FIND request and not more. Is this correct?

2. When it comes to Matching Key Types I am currently interpreting the type R and O from Table K.6-1 in K.6.1.2.2 the following ways: R == each SCP is required to support matching against provided values; O == SCPs can support matching against provided values but is not required to support it, but if the Attribute has a Return Key Type of 1, the SCP is required to return it even if it does not support matching against a provided value. (e..g. Requested Procedure ID (0040,1001) is part of my C-FIND query identifier (not as matching key): am I correct to assume that every MWL SCP will return a (valid) value for this attribute since its Return Key Type is 1?)

3. Is it valid for an MWL SCU to send an C-FIND request with an identifier without any provided matching key value (so just a list of attributes with Zero Length values) and expect that the MWL SCP returns its items?

4. Is it safe for the SCU to assume that all returned MWL items by the SCP are in fact completely valid and that no requested attribute of Return Key Type 1 will be included in the MWL responses without an proper value? Should there be an additional check on the SCU side in place to validated that and in case dump such a broken MWL response?

I would really appreciate if a few of you could join me on these questions so that I can finally wrap my head around them.

Kind regards,
madMorty

Re: MWL - Return Key Attributes of Type 1

<a478ceb7-947f-4a20-9242-24d2f65803aan@googlegroups.com>

  copy mid

https://www.rocksolidbbs.com/devel/article-flat.php?id=288&group=comp.protocols.dicom#288

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:ad4:5b82:: with SMTP id 2mr3654220qvp.22.1642772658917;
Fri, 21 Jan 2022 05:44:18 -0800 (PST)
X-Received: by 2002:a05:620a:40c1:: with SMTP id g1mr2678003qko.41.1642772658478;
Fri, 21 Jan 2022 05:44:18 -0800 (PST)
Path: i2pn2.org!i2pn.org!usenet.goja.nl.eu.org!news.freedyn.de!newsreader4.netcologne.de!news.netcologne.de!peer03.ams1!peer.ams1.xlned.com!news.xlned.com!peer02.iad!feed-me.highwinds-media.com!news.highwinds-media.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Fri, 21 Jan 2022 05:44:18 -0800 (PST)
In-Reply-To: <f772ebb7-7c9c-4357-ad13-3dea60a50f72n@googlegroups.com>
Injection-Info: google-groups.googlegroups.com; posting-host=46.142.183.217; posting-account=6ksO_woAAABuoPrA50nzzcpphnSbofar
NNTP-Posting-Host: 46.142.183.217
References: <f772ebb7-7c9c-4357-ad13-3dea60a50f72n@googlegroups.com>
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <a478ceb7-947f-4a20-9242-24d2f65803aan@googlegroups.com>
Subject: Re: MWL - Return Key Attributes of Type 1
From: thomas.freier@medavis.de (Thomas Freier)
Injection-Date: Fri, 21 Jan 2022 13:44:18 +0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Received-Bytes: 4077
 by: Thomas Freier - Fri, 21 Jan 2022 13:44 UTC

> 1. From my understanding the SCP will/should only ever return attributes within its MWL responses that where originally part of the SCU identifier within its C-FIND request and not more. Is this correct?

Correct should not, but expect in practice that some SCPs may return more. So I would implement it to ignore attributes you don't need.
>
> 2. When it comes to Matching Key Types I am currently interpreting the type R and O from Table K.6-1 in K.6.1.2.2 the following ways: R == each SCP is required to support matching against provided values;
Yes. Kind of difficult to read the table ;) but you got it really well.

> O == SCPs can support matching against provided values but is not required to support it,
Optional attribute supported will be listed in the scp conformance statement.

> but if the Attribute has a Return Key Type of 1, the SCP is required to return it even if it does not support matching against a provided value. (e.g. Requested Procedure ID (0040,1001) is part of my C-FIND query identifier (not as matching key): am I correct to assume that every MWL SCP will return a (valid) value for this attribute since its Return Key Type is 1?)
>
Yes correct.

> 3. Is it valid for an MWL SCU to send an C-FIND request with an identifier without any provided matching key value (so just a list of attributes with Zero Length values) and expect that the MWL SCP returns its items?
Good question my opinion , someone with better DICOM knowledge may have a different interpretation.
According to Part 3.4 "An Identifier in a C-FIND request shall contain values​ to be matched against the Attributes of the Entities in a Worklist Information Model." I interpret "contain values" as shall have at minimum one value provided.
Anyway I would not try to do this in practice it may generate failure status or even an abort association. I am curious what is the use-case to query for all worklist items? Especially for an undefined timeframe.

>
> 4. Is it safe for the SCU to assume that all returned MWL items by the SCP are in fact completely valid and that no requested attribute of Return Key Type 1 will be included in the MWL responses without an proper value? Should there be an additional check on the SCU side in place to validated that and in case dump such a broken MWL response?

From my experience you should not expect or restrict too much. Check for the validity of attributes you really need and then accept it. Depends of your specific use-case of course. Generally speaking when creating a DICOM Request implement it strictly to the standard. When receiving a response check it for compliance just as much as you need and ignore the rest. Of course check for valid status.

Best regards
Thomas

Re: MWL - Return Key Attributes of Type 1

<6c436c82-9573-489d-a0c0-6804ce585d86n@googlegroups.com>

  copy mid

https://www.rocksolidbbs.com/devel/article-flat.php?id=292&group=comp.protocols.dicom#292

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:a05:622a:1a28:: with SMTP id f40mr5828662qtb.391.1643015563270;
Mon, 24 Jan 2022 01:12:43 -0800 (PST)
X-Received: by 2002:a05:620a:4308:: with SMTP id u8mr10249857qko.606.1643015563115;
Mon, 24 Jan 2022 01:12:43 -0800 (PST)
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!news.misty.com!border2.nntp.dca1.giganews.com!nntp.giganews.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Mon, 24 Jan 2022 01:12:42 -0800 (PST)
In-Reply-To: <a478ceb7-947f-4a20-9242-24d2f65803aan@googlegroups.com>
Injection-Info: google-groups.googlegroups.com; posting-host=2003:d7:ff01:2d00:b689:8d1d:103b:c27;
posting-account=JEyPZwoAAADgvqXlfDn3_bdujWVbq4jy
NNTP-Posting-Host: 2003:d7:ff01:2d00:b689:8d1d:103b:c27
References: <f772ebb7-7c9c-4357-ad13-3dea60a50f72n@googlegroups.com> <a478ceb7-947f-4a20-9242-24d2f65803aan@googlegroups.com>
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <6c436c82-9573-489d-a0c0-6804ce585d86n@googlegroups.com>
Subject: Re: MWL - Return Key Attributes of Type 1
From: madmortyonthehunt@gmail.com (madMorty)
Injection-Date: Mon, 24 Jan 2022 09:12:43 +0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Lines: 37
 by: madMorty - Mon, 24 Jan 2022 09:12 UTC

Thanks Thomas for your inital feedback.

> Good question my opinion , someone with better DICOM knowledge may have a different interpretation.
> According to Part 3.4 "An Identifier in a C-FIND request shall contain values​ to be matched against the Attributes of the Entities in a Worklist Information Model." I interpret "contain values" as shall have at minimum one value provided.
> Anyway I would not try to do this in practice it may generate failure status or even an abort association. I am curious what is the use-case to query for all worklist items? Especially for an undefined timeframe.
That is the same point where I am unsure within the standard wether "contain values" means that there must be at least one matching key with a provided value within the identifier or not. Also the text from K.4.1.3.1 ""Worklist" Search Method" could not make it clear to me if at least one matching key value must be provided within the SCU request identifier or not. I tested sending a C-FIND request with an identifier without any matching key value to the ORTHANC MWL plugin and DVTk RIS Emulator and both returned their MWL items. But I would really like to know if that behaviour is valid with the standard and should/can be expected from any MWL SCP. Mabye to give an idea how I came up with that in the first place: I somewhat compare the matching keys to "WHERE" clause in SQL to filter and thought if I do not care about filtering at all, I just send them also with Zero Length (so just like Return Keys).

Regarind the use-case why I came up with such a query: I thought about very small doctors's offices where there are maby about 10-20 examinations scheduled for a day and because of that small amount of examinations there would be not much gained with setting up filters for the MWL query in the first place. And to save those users from the burden to grapple with MWL matching key setup, I just would per default not set any matching/filtering key value options. (For any bigger medical infrastructor I would expect that there is an dedicated IT/DICOM administrator that would not have any problems with setting up the correct matching key options on the device.)

Best regards
Morty

1
server_pubkey.txt

rocksolid light 0.9.81
clearnet tor