I want to call a C++ function from Fortran. The function is
called jband, in the file jband.cpp. The function is of type
long double, and so is its argument tbar.
I wrote this:

module STUFF
integer, parameter :: dbl=selected_real_kind(14)
integer, parameter :: qud=selected_real_kind(30)
end module STUFF
program JBAND_TEST
use STUFF; implicit none
real(dbl) :: curr, FORTJBAND
real(qud) :: tbar
do
read *, tbar
if (tbar < 0) exit
curr = FORTJBAND (tbar)
print '(" curr =", f10.4)', curr
enddo
end program JBAND_TEST

function FORTJBAND (tbar)
use STUFF; implicit none
interface
function JBAND (tbar) bind(c)
import JBAND, c_long_double
import tbar, c_long_double
end function JBAND
end interface
real(dbl) :: FORTJBAND
real(qud) :: tbar
FORTJBAND = JBAND (tbar)
end function FORTJBAND

I run this using this script

g++ -o jband.o jband.cpp
gfortran -o jbandtest.o jbandtest.f90
gfortran jband.o jbandtest.o
../a.out << eoi
1.0
-1
eoi
rm a.out jband.o jbandtest.o

and I get this output

/usr/bin/ld:
/usr/lib/gcc/x86_64-linux-gnu/11/../../../x86_64-linux-gnu/Scrt1.o: in
function `_start':
(.text+0x1b): undefined reference to `main'
collect2: error: ld returned 1 exit status
jbandtest.f90:21:31:

21 | import JBAND, c_long_double
| 1
Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
does not exist.
jbandtest.f90:22:30:

22 | import tbar, c_long_double
| 1
Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
does not exist.
jbandtest.f90:27:14:

27 | FORTJBAND = JBAND (tbar)
| 1
Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(4)
[...]

So there is a communication problem with agreeing on the C++
type long double.
I have tried making everything in jband plain double, making
the two statements

import JBAND, c_double
import tbar, c_double

but now it says that C-double doesn't exist.

Any ideas?

--
Dieter Britz

On Sat, 9 Sep 2023 10:54:33 +0200
db <dieterhansbritz@gmail.com> wrote:
>but now it says that C-double doesn't exist.
>
>Any ideas?

C++ mangles function names so that the name you give the function isn't the
name the dynamic loader sees in the binary. You need to put this around whatever
function you want to call from Fortran so it has C style linkage which means
the name remains the same:

extern "C" {

void calledFromFortran()
{ :
}

}

On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
> On Sat, 9 Sep 2023 10:54:33 +0200
> db <dieterhansbritz@gmail.com> wrote:
>> but now it says that C-double doesn't exist.
>>
>> Any ideas?
>
> C++ mangles function names so that the name you give the function isn't the
> name the dynamic loader sees in the binary. You need to put this around whatever
> function you want to call from Fortran so it has C style linkage which means
> the name remains the same:
>
> extern "C" {
>
> void calledFromFortran()
> {
> :
> }
>
> }
>

Like this:

const long double iband(const long double tbar)
extern "C" {

void calledFromFortran()
{ :
}

}

? Why the extra } ?
--
Dieter Britz

On Sat, 9 Sep 2023 12:47:38 +0200
db <dieterhansbritz@gmail.com> wrote:
>On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>> On Sat, 9 Sep 2023 10:54:33 +0200
>> db <dieterhansbritz@gmail.com> wrote:
>>> but now it says that C-double doesn't exist.
>>>
>>> Any ideas?
>>
>> C++ mangles function names so that the name you give the function isn't the
>> name the dynamic loader sees in the binary. You need to put this around
>whatever
>> function you want to call from Fortran so it has C style linkage which means
>> the name remains the same:
>>
>> extern "C" {
>>
>> void calledFromFortran()
>> {
>> :
>> }
>>
>> }
>>
>
>Like this:

No. calledFromFortran was an example function.

extern "C" {

const long double iband(const long double tbar)
{ :
}

}

>? Why the extra } ?

What extra } ? The brackets balance.

On 09.09.2023 12.47, db wrote:
> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>> On Sat, 9 Sep 2023 10:54:33 +0200
>> db <dieterhansbritz@gmail.com> wrote:
>>> but now it says that C-double doesn't exist.
>>>
>>> Any ideas?
>>
>> C++ mangles function names so that the name you give the function
>> isn't the
>> name the dynamic loader sees in the binary. You need to put this
>> around whatever
>> function you want to call from Fortran so it has C style linkage which
>> means
>> the name remains the same:
>>
>> extern "C" {
>>
>> void calledFromFortran()
>> {
>>     :
>> }
>>
>> }
>>
>
> Like this:
>
> const long double iband(const long double tbar)
> extern "C" {
>
> void calledFromFortran()
> {
>     :
> }
>
> }
>
> ? Why the extra } ?

Now I get a new error, due to this "extern"

~/ownlib90/tests> ./jbandtest
jband.cpp:88:1: error: expected initializer before 'extern'
88 | extern "C" {
| ^~~~~~
jband.cpp:96:1: error: expected unqualified-id before '{' token
96 | {
| ^
jbandtest.f90:21:31:

21 | import JBAND, c_long_double
| 1
Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
does not exist.
[...]

--
Dieter Britz

On Sat, 9 Sep 2023 12:52:42 +0200
db <dieterhansbritz@gmail.com> wrote:
>On 09.09.2023 12.47, db wrote:
>Now I get a new error, due to this "extern"
>
>~/ownlib90/tests> ./jbandtest
>jband.cpp:88:1: error: expected initializer before 'extern'
> 88 | extern "C" {
> | ^~~~~~
>jband.cpp:96:1: error: expected unqualified-id before '{' token
> 96 | {
> | ^
>jbandtest.f90:21:31:
>
> 21 | import JBAND, c_long_double
> | 1
>Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
>does not exist.
>[...]

If your knowledge of C++ syntax is so basic you don't know which bits go
where I'd suggest getting someone else to write the C++ code and you stick
to fortran.

09.09.2023 13:52 db kirjutas:
> On 09.09.2023 12.47, db wrote:
>> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>>> On Sat, 9 Sep 2023 10:54:33 +0200
>>> db <dieterhansbritz@gmail.com> wrote:
>>>> but now it says that C-double doesn't exist.
>>>>
>>>> Any ideas?
>>>
>>> C++ mangles function names so that the name you give the function
>>> isn't the
>>> name the dynamic loader sees in the binary. You need to put this
>>> around whatever
>>> function you want to call from Fortran so it has C style linkage
>>> which means
>>> the name remains the same:
>>>
>>> extern "C" {
>>>
>>> void calledFromFortran()
>>> {
>>>     :
>>> }
>>>
>>> }
>>>
>>
>> Like this:
>>
>> const long double iband(const long double tbar)
>> extern "C" {
>>
>> void calledFromFortran()
>> {
>>      :
>> }
>>
>> }
>>
>> ? Why the extra } ?
>
> Now I get a new error, due to this "extern"
>
> ~/ownlib90/tests> ./jbandtest
> jband.cpp:88:1: error: expected initializer before 'extern'
>    88 | extern "C" {
>       | ^~~~~~
> jband.cpp:96:1: error: expected unqualified-id before '{' token
>    96 | {
>       | ^

Assuming you are indeed compiling this as C++ as intended, the problem
must be with the preceding content.

> jbandtest.f90:21:31:
>
>    21 |     import JBAND, c_long_double
>       |                               1
> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
> does not exist.
> [...]

This is a fortran error message. It's not very likely you will get any
help about this here, most people here do not know anything about fortran.

On 2023-09-09 12:47 PM, db wrote:
> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>> On Sat, 9 Sep 2023 10:54:33 +0200
>> db <dieterhansbritz@gmail.com> wrote:
>>> but now it says that C-double doesn't exist.
>>>
>>> Any ideas?
>>
>> C++ mangles function names so that the name you give the function
>> isn't the
>> name the dynamic loader sees in the binary. You need to put this
>> around whatever
>> function you want to call from Fortran so it has C style linkage which
>> means
>> the name remains the same:
>>
>> extern "C" {
>>
>> void calledFromFortran()
>> {
>>     :
>> }
>>
>> }
>>
>
> Like this:
>
> const long double iband(const long double tbar)

Why did you add that?

You could at least try to do /exactly/ the example given by a
knowledgeable person.

> extern "C" {
>
> void calledFromFortran()
> {
>     :
> }
>
> }
>
> ? Why the extra } ?

On 09.09.2023 13.00, Muttley@dastardlyhq.com wrote:
> On Sat, 9 Sep 2023 12:52:42 +0200
> db <dieterhansbritz@gmail.com> wrote:
>> On 09.09.2023 12.47, db wrote:
>> Now I get a new error, due to this "extern"
>>
>> ~/ownlib90/tests> ./jbandtest
>> jband.cpp:88:1: error: expected initializer before 'extern'
>> 88 | extern "C" {
>> | ^~~~~~
>> jband.cpp:96:1: error: expected unqualified-id before '{' token
>> 96 | {
>> | ^
>> jbandtest.f90:21:31:
>>
>> 21 | import JBAND, c_long_double
>> | 1
>> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
>> does not exist.
>> [...]
>
> If your knowledge of C++ syntax is so basic you don't know which bits go
> where I'd suggest getting someone else to write the C++ code and you stick
> to fortran.
>

An unhelpful comment..
The C++ function was written by an experienced C++
programmer, and my problem is calling it from Fortran.
OK, I missed the extra opening {. The problem lies
in the communication between Fortran and C++.
--
Dieter Britz

On 09.09.2023 15.56, Paavo Helde wrote:
> 09.09.2023 13:52 db kirjutas:
>> On 09.09.2023 12.47, db wrote:
>>> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>>>> On Sat, 9 Sep 2023 10:54:33 +0200
>>>> db <dieterhansbritz@gmail.com> wrote:
>>>>> but now it says that C-double doesn't exist.
>>>>>
>>>>> Any ideas?
>>>>
>>>> C++ mangles function names so that the name you give the function
>>>> isn't the
>>>> name the dynamic loader sees in the binary. You need to put this
>>>> around whatever
>>>> function you want to call from Fortran so it has C style linkage
>>>> which means
>>>> the name remains the same:
>>>>
>>>> extern "C" {
>>>>
>>>> void calledFromFortran()
>>>> {
>>>>     :
>>>> }
>>>>
>>>> }
>>>>
>>>
>>> Like this:
>>>
>>> const long double iband(const long double tbar)
>>> extern "C" {
>>>
>>> void calledFromFortran()
>>> {
>>>      :
>>> }
>>>
>>> }
>>>
>>> ? Why the extra } ?
>>
>> Now I get a new error, due to this "extern"
>>
>> ~/ownlib90/tests> ./jbandtest
>> jband.cpp:88:1: error: expected initializer before 'extern'
>>     88 | extern "C" {
>>        | ^~~~~~
>> jband.cpp:96:1: error: expected unqualified-id before '{' token
>>     96 | {
>>        | ^
>
> Assuming you are indeed compiling this as C++ as intended, the problem
> must be with the preceding content.
>
>> jbandtest.f90:21:31:
>>
>>     21 |     import JBAND, c_long_double
>>        |                               1
>> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
>> does not exist.
>> [...]
>
> This is a fortran error message. It's not very likely you will get any
> help about this here, most people here do not know anything about fortran.
>
I have tried that but so far no one was able to help there,
so I thought I'd try at the other end. No go here either.
Ar well, I might have to myself translate the C++ code into
Fortran. I have done that with another routine and it was
quite laborious.
--
Dieter Britz

On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
> On Sat, 9 Sep 2023 10:54:33 +0200
> db <dieterhansbritz@gmail.com> wrote:
>> but now it says that C-double doesn't exist.
>>
>> Any ideas?
>
> C++ mangles function names so that the name you give the function isn't the
> name the dynamic loader sees in the binary. You need to put this around whatever
> function you want to call from Fortran so it has C style linkage which means
> the name remains the same:
>
> extern "C" {
>
> void calledFromFortran()
> {
> :
> }
>
> }
>
Where should this go in the code? I added it at the end as is,
and now I get this:

~/ownlib90/tests> ./jbandtest
jband.cpp:88:1: error: expected initializer before 'extern'
88 | extern "C" {
| ^~~~~~
jband.cpp:96:1: error: expected unqualified-id before '{' token
96 | {
| ^
jband.cpp: In function 'void calledFromFortran()':
jband.cpp:350:9: error: expected primary-expression before ':' token
350 | :
...

--
Dieter Britz

db <dieterhansbritz@gmail.com> writes:

> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>> On Sat, 9 Sep 2023 10:54:33 +0200
>> db <dieterhansbritz@gmail.com> wrote:
>>> but now it says that C-double doesn't exist.
>>>
>>> Any ideas?
>> C++ mangles function names so that the name you give the function isn't
>> the
>> name the dynamic loader sees in the binary. You need to put this around whatever
>> function you want to call from Fortran so it has C style linkage which means
>> the name remains the same:
>> extern "C" {
>> void calledFromFortran()
>> {
>> :
>> }
>> }
>>
> Where should this go in the code? I added it at the end as is,
> and now I get this:
>
> ~/ownlib90/tests> ./jbandtest
> jband.cpp:88:1: error: expected initializer before 'extern'
> 88 | extern "C" {
> | ^~~~~~
> jband.cpp:96:1: error: expected unqualified-id before '{' token
> 96 | {
> | ^
> jband.cpp: In function 'void calledFromFortran()':
> jband.cpp:350:9: error: expected primary-expression before ':' token
> 350 | :
> ...

You are giving people very little to go on. There's an unknown command
(./jbandtest) the gives some errors where only one line of code can be
seen.

Can you produce a cut-down version to the program that shows the same
error -- mimimal example of the C++ and of the Fortran that should
calls it but which fails? That would mean you could post the code.

If that is not possible, can you link to the source so those who know
both C++ and Fortran can take a proper look?

--
Ben.

On 2023-09-09 at 12:52, db wrote:
> On 09.09.2023 12.47, db wrote:
>> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>>> On Sat, 9 Sep 2023 10:54:33 +0200
>>> db <dieterhansbritz@gmail.com> wrote:
>>>> but now it says that C-double doesn't exist.
>>>>
>>>> Any ideas?
>>>
>>> C++ mangles function names so that the name you give the function
>>> isn't the
>>> name the dynamic loader sees in the binary. You need to put this
>>> around whatever
>>> function you want to call from Fortran so it has C style linkage
>>> which means
>>> the name remains the same:
>>>
>>> extern "C" {
>>>
>>> void calledFromFortran()
>>> {
>>>     :
>>> }
>>>
>>> }
>>>
>>
>> Like this:
>>
>> const long double iband(const long double tbar)
>> extern "C" {
>>
>> void calledFromFortran()
>> {
>>      :
>> }
>>
>> }
>>
>> ? Why the extra } ?
>
> Now I get a new error, due to this "extern"
>
> ~/ownlib90/tests> ./jbandtest
> jband.cpp:88:1: error: expected initializer before 'extern'
>    88 | extern "C" {
>       | ^~~~~~

I wild guess here is that the line *before* this is where something is
missing. The message is just that 'extern' was not expected here, but
something else.

On Saturday, September 9, 2023 at 11:54:53 AM UTC+3, db wrote:
> I want to call a C++ function from Fortran. The function is
> called jband, in the file jband.cpp. The function is of type
> long double, and so is its argument tbar.
> I wrote this:
>
> module STUFF
> integer, parameter :: dbl=selected_real_kind(14)
> integer, parameter :: qud=selected_real_kind(30)
> end module STUFF
> program JBAND_TEST
> use STUFF; implicit none
> real(dbl) :: curr, FORTJBAND
> real(qud) :: tbar
> do
> read *, tbar
> if (tbar < 0) exit
> curr = FORTJBAND (tbar)
> print '(" curr =", f10.4)', curr
> enddo
> end program JBAND_TEST
>
> function FORTJBAND (tbar)
> use STUFF; implicit none
> interface
> function JBAND (tbar) bind(c)
> import JBAND, c_long_double
> import tbar, c_long_double
> end function JBAND
> end interface
> real(dbl) :: FORTJBAND
> real(qud) :: tbar
> FORTJBAND = JBAND (tbar)
> end function FORTJBAND
>
> I run this using this script
>
> g++ -o jband.o jband.cpp

That's command is wrong. Should be:
g++ -c -o jband.o jband.cpp

> gfortran -o jbandtest.o jbandtest.f90
> gfortran jband.o jbandtest.o
> ./a.out << eoi
> 1.0
> -1
> eoi
> rm a.out jband.o jbandtest.o
>
> and I get this output
>
> /usr/bin/ld:
> /usr/lib/gcc/x86_64-linux-gnu/11/../../../x86_64-linux-gnu/Scrt1.o: in
> function `_start':
> (.text+0x1b): undefined reference to `main'
> collect2: error: ld returned 1 exit status
> jbandtest.f90:21:31:
>
> 21 | import JBAND, c_long_double
> | 1
> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
> does not exist.
> jbandtest.f90:22:30:
>
> 22 | import tbar, c_long_double
> | 1
> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
> does not exist.
> jbandtest.f90:27:14:
>
> 27 | FORTJBAND = JBAND (tbar)
> | 1
> Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(4)
> [...]
>
> So there is a communication problem with agreeing on the C++
> type long double.
> I have tried making everything in jband plain double, making
> the two statements
>
> import JBAND, c_double
> import tbar, c_double
>
> but now it says that C-double doesn't exist.
>
> Any ideas?
>
>
>
> --
> Dieter Britz

10.09.2023 15:33 db kirjutas:

> The C++ function was written by an experienced C++
> programmer, and my problem is calling it from Fortran.
> OK, I missed the extra opening {. The problem lies
> in the communication between Fortran and C++.

From C++ side it's necessary to declare and compile the function extern
"C" and it must be exported from the resulting shared library (by
__declspec(dllexport) or __attribute__ ((visibility ("default"))),
depending on the platform).

For sure an experienced C++ programmer is able to do that easily. After
that, the ball is on the Fortran side.

Ben Bacarisse <ben.usenet@bsb.me.uk> writes:

> db <dieterhansbritz@gmail.com> writes:
>
>> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>>> On Sat, 9 Sep 2023 10:54:33 +0200
>>> db <dieterhansbritz@gmail.com> wrote:
>>>> but now it says that C-double doesn't exist.
>>>>
>>>> Any ideas?
>>> C++ mangles function names so that the name you give the function isn't
>>> the
>>> name the dynamic loader sees in the binary. You need to put this around whatever
>>> function you want to call from Fortran so it has C style linkage which means
>>> the name remains the same:
>>> extern "C" {
>>> void calledFromFortran()
>>> {
>>> :
>>> }
>>> }
>>>
>> Where should this go in the code? I added it at the end as is,
>> and now I get this:
>>
>> ~/ownlib90/tests> ./jbandtest
>> jband.cpp:88:1: error: expected initializer before 'extern'
>> 88 | extern "C" {
>> | ^~~~~~
>> jband.cpp:96:1: error: expected unqualified-id before '{' token
>> 96 | {
>> | ^
>> jband.cpp: In function 'void calledFromFortran()':
>> jband.cpp:350:9: error: expected primary-expression before ':' token
>> 350 | :
>> ...
>
> You are giving people very little to go on. There's an unknown command
> (./jbandtest) the gives some errors where only one line of code can be
> seen.
>
> Can you produce a cut-down version to the program that shows the same
> error -- mimimal example of the C++ and of the Fortran that should
> calls it but which fails? That would mean you could post the code.

I see you have indeed posted half of it. If you post the C++ source,
someone might be able to help with both parts. I can tell you a bit
about what's wrong with the Fortran you posted, but I need to see the
other half.

--
Ben.

On Saturday, September 9, 2023 at 11:54:53 AM UTC+3, db wrote:
> I want to call a C++ function from Fortran. The function is
> called jband, in the file jband.cpp. The function is of type
> long double, and so is its argument tbar.
> I wrote this:
>
> module STUFF
> integer, parameter :: dbl=selected_real_kind(14)
> integer, parameter :: qud=selected_real_kind(30)
> end module STUFF
> program JBAND_TEST
> use STUFF; implicit none
> real(dbl) :: curr, FORTJBAND
> real(qud) :: tbar
> do
> read *, tbar
> if (tbar < 0) exit
> curr = FORTJBAND (tbar)
> print '(" curr =", f10.4)', curr
> enddo
> end program JBAND_TEST
>
> function FORTJBAND (tbar)
> use STUFF; implicit none
> interface
> function JBAND (tbar) bind(c)
> import JBAND, c_long_double
> import tbar, c_long_double
> end function JBAND
> end interface
> real(dbl) :: FORTJBAND
> real(qud) :: tbar
> FORTJBAND = JBAND (tbar)
> end function FORTJBAND
>
> I run this using this script
>
> g++ -o jband.o jband.cpp
> gfortran -o jbandtest.o jbandtest.f90
> gfortran jband.o jbandtest.o
> ./a.out << eoi
> 1.0
> -1
> eoi
> rm a.out jband.o jbandtest.o
>
> and I get this output
>
> /usr/bin/ld:
> /usr/lib/gcc/x86_64-linux-gnu/11/../../../x86_64-linux-gnu/Scrt1.o: in
> function `_start':
> (.text+0x1b): undefined reference to `main'
> collect2: error: ld returned 1 exit status
> jbandtest.f90:21:31:
>
> 21 | import JBAND, c_long_double
> | 1
> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
> does not exist.
> jbandtest.f90:22:30:
>
> 22 | import tbar, c_long_double
> | 1
> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
> does not exist.
> jbandtest.f90:27:14:
>
> 27 | FORTJBAND = JBAND (tbar)
> | 1
> Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(4)
> [...]
>
> So there is a communication problem with agreeing on the C++
> type long double.
> I have tried making everything in jband plain double, making
> the two statements
>
> import JBAND, c_double
> import tbar, c_double
>
> but now it says that C-double doesn't exist.
>
> Any ideas?
>
>
>
> --
> Dieter Britz

I manged to pass link. 99% of the problems appear to have nothing to do
with C++ language. It's partly bad Fortran, partly wrong size of floating-point
types and partly forgotten -c flag in compilation commands.

That's my Fortran (f90) source code:

module STUFF
integer, parameter :: dbl=selected_real_kind(14)
integer, parameter :: qud=selected_real_kind(30)
end module STUFF

module abc
use, intrinsic :: iso_c_binding
interface
function JBAND (tbar) bind(c)
import c_long_double
real(c_long_double) :: JBAND
real(c_long_double) :: tbar
end function JBAND
end interface
end module abc

function FORTJBAND (tbar)
use STUFF;
use abc;
implicit none
real(dbl) :: FORTJBAND
real(qud) :: tbar
real(10) :: tbar10
real(10) :: res10
tbar10 = tbar
res10 = JBAND (tbar10)
FORTJBAND = res10
end function FORTJBAND

program JBAND_TEST
use STUFF;
implicit none
real(dbl) :: curr, FORTJBAND
real(qud) :: tbar
do
read *, tbar
if (tbar < 0) exit
curr = FORTJBAND (tbar)
print '(" curr =", f10.4)', curr
enddo
end program JBAND_TEST

That's my C++ source code (1 line)
extern "C" long double jband(long double x) { return x; }

That's my compilation commands:
g++ -c -o jband.o jband.cpp
gfortran -c -o jbandtest.o jbandtest.f90
gfortran jband.o jbandtest.o

Now I have no idea if it works like intended or not

While "C" and "C++" are the only language linkages for which support is
mandated by the standard, the description of language linkage is clearly
intended to allow support for a wider range of language linkages. Could
anyone tell me which implementatins, if any, support language linkages
other than "C" and C++"? If so, what languages do they support? How well
does the feature work? Is there any significant amount of use relying on
that feature?
In particular, and relevant to this thread, does any implementation
support "Fortran" language linkage?

On Sun, 10 Sep 2023 14:33:26 +0200
db <dieterhansbritz@gmail.com> wrote:
>On 09.09.2023 13.00, Muttley@dastardlyhq.com wrote:
>> On Sat, 9 Sep 2023 12:52:42 +0200
>> db <dieterhansbritz@gmail.com> wrote:
>>> On 09.09.2023 12.47, db wrote:
>>> Now I get a new error, due to this "extern"
>>>
>>> ~/ownlib90/tests> ./jbandtest
>>> jband.cpp:88:1: error: expected initializer before 'extern'
>>> 88 | extern "C" {
>>> | ^~~~~~
>>> jband.cpp:96:1: error: expected unqualified-id before '{' token
>>> 96 | {
>>> | ^
>>> jbandtest.f90:21:31:
>>>
>>> 21 | import JBAND, c_long_double
>>> | 1
>>> Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
>>> does not exist.
>>> [...]
>>
>> If your knowledge of C++ syntax is so basic you don't know which bits go
>> where I'd suggest getting someone else to write the C++ code and you stick
>> to fortran.
>>
>
>An unhelpful comment..
>The C++ function was written by an experienced C++
>programmer, and my problem is calling it from Fortran.
>OK, I missed the extra opening {. The problem lies
>in the communication between Fortran and C++.

If you're having trouble with this kind of basic stuff I think you're going
to have a lot more problems down the line with this.

If you're in contact with the guy who wrote the C++ code I would suggest
talking to him about it.

On Sunday, September 10, 2023 at 7:51:56 PM UTC+3, Michael S wrote:
> On Saturday, September 9, 2023 at 11:54:53 AM UTC+3, db wrote:
> > I want to call a C++ function from Fortran. The function is
> > called jband, in the file jband.cpp. The function is of type
> > long double, and so is its argument tbar.
> > I wrote this:
> >
> > module STUFF
> > integer, parameter :: dbl=selected_real_kind(14)
> > integer, parameter :: qud=selected_real_kind(30)
> > end module STUFF
> > program JBAND_TEST
> > use STUFF; implicit none
> > real(dbl) :: curr, FORTJBAND
> > real(qud) :: tbar
> > do
> > read *, tbar
> > if (tbar < 0) exit
> > curr = FORTJBAND (tbar)
> > print '(" curr =", f10.4)', curr
> > enddo
> > end program JBAND_TEST
> >
> > function FORTJBAND (tbar)
> > use STUFF; implicit none
> > interface
> > function JBAND (tbar) bind(c)
> > import JBAND, c_long_double
> > import tbar, c_long_double
> > end function JBAND
> > end interface
> > real(dbl) :: FORTJBAND
> > real(qud) :: tbar
> > FORTJBAND = JBAND (tbar)
> > end function FORTJBAND
> >
> > I run this using this script
> >
> > g++ -o jband.o jband.cpp
> > gfortran -o jbandtest.o jbandtest.f90
> > gfortran jband.o jbandtest.o
> > ./a.out << eoi
> > 1.0
> > -1
> > eoi
> > rm a.out jband.o jbandtest.o
> >
> > and I get this output
> >
> > /usr/bin/ld:
> > /usr/lib/gcc/x86_64-linux-gnu/11/../../../x86_64-linux-gnu/Scrt1.o: in
> > function `_start':
> > (.text+0x1b): undefined reference to `main'
> > collect2: error: ld returned 1 exit status
> > jbandtest.f90:21:31:
> >
> > 21 | import JBAND, c_long_double
> > | 1
> > Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
> > does not exist.
> > jbandtest.f90:22:30:
> >
> > 22 | import tbar, c_long_double
> > | 1
> > Error: Cannot IMPORT 'c_long_double' from host scoping unit at (1) -
> > does not exist.
> > jbandtest.f90:27:14:
> >
> > 27 | FORTJBAND = JBAND (tbar)
> > | 1
> > Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(4)
> > [...]
> >
> > So there is a communication problem with agreeing on the C++
> > type long double.
> > I have tried making everything in jband plain double, making
> > the two statements
> >
> > import JBAND, c_double
> > import tbar, c_double
> >
> > but now it says that C-double doesn't exist.
> >
> > Any ideas?
> >
> >
> >
> > --
> > Dieter Britz
> I manged to pass link. 99% of the problems appear to have nothing to do
> with C++ language. It's partly bad Fortran, partly wrong size of floating-point
> types and partly forgotten -c flag in compilation commands.
>
> That's my Fortran (f90) source code:
> module STUFF
> integer, parameter :: dbl=selected_real_kind(14)
> integer, parameter :: qud=selected_real_kind(30)
> end module STUFF
> module abc
> use, intrinsic :: iso_c_binding
> interface
> function JBAND (tbar) bind(c)
> import c_long_double
> real(c_long_double) :: JBAND
> real(c_long_double) :: tbar
> end function JBAND
> end interface
> end module abc
> function FORTJBAND (tbar)
> use STUFF;
> use abc;
> implicit none
> real(dbl) :: FORTJBAND
> real(qud) :: tbar
> real(10) :: tbar10
> real(10) :: res10
> tbar10 = tbar
> res10 = JBAND (tbar10)
> FORTJBAND = res10
> end function FORTJBAND
> program JBAND_TEST
> use STUFF;
> implicit none
> real(dbl) :: curr, FORTJBAND
> real(qud) :: tbar
> do
> read *, tbar
> if (tbar < 0) exit
> curr = FORTJBAND (tbar)
> print '(" curr =", f10.4)', curr
> enddo
> end program JBAND_TEST
> That's my C++ source code (1 line)
> extern "C" long double jband(long double x) { return x; }
>
> That's my compilation commands:
> g++ -c -o jband.o jband.cpp
> gfortran -c -o jbandtest.o jbandtest.f90
> gfortran jband.o jbandtest.o
>
> Now I have no idea if it works like intended or not

Tested it. It was incorrect, but by lucky chance worked on x86-64 Windows.
No such luck on x86-64 Linux.
Here is the correct syntax that works both on Windows and on Linux:

module abc
use, intrinsic :: iso_c_binding
interface
real(c_long_double) function JBAND (tbar) bind(c)
import c_long_double
real(c_long_double), value :: tbar
end function JBAND
end interface
end module abc

I actually understand why the previous version worked on Windows
despite being incorrect, but I don't believe that explanation is of
interest for OP.

On 10.09.2023 15.22, Ben Bacarisse wrote:
> db <dieterhansbritz@gmail.com> writes:
>
>> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>>> On Sat, 9 Sep 2023 10:54:33 +0200
>>> db <dieterhansbritz@gmail.com> wrote:
>>>> but now it says that C-double doesn't exist.
>>>>
>>>> Any ideas?
>>> C++ mangles function names so that the name you give the function isn't
>>> the
>>> name the dynamic loader sees in the binary. You need to put this around whatever
>>> function you want to call from Fortran so it has C style linkage which means
>>> the name remains the same:
>>> extern "C" {
>>> void calledFromFortran()
>>> {
>>> :
>>> }
>>> }
>>>
>> Where should this go in the code? I added it at the end as is,
>> and now I get this:
>>
>> ~/ownlib90/tests> ./jbandtest
>> jband.cpp:88:1: error: expected initializer before 'extern'
>> 88 | extern "C" {
>> | ^~~~~~
>> jband.cpp:96:1: error: expected unqualified-id before '{' token
>> 96 | {
>> | ^
>> jband.cpp: In function 'void calledFromFortran()':
>> jband.cpp:350:9: error: expected primary-expression before ':' token
>> 350 | :
>> ...
>
> You are giving people very little to go on. There's an unknown command
> (./jbandtest) the gives some errors where only one line of code can be
> seen.
>
> Can you produce a cut-down version to the program that shows the same
> error -- mimimal example of the C++ and of the Fortran that should
> calls it but which fails? That would mean you could post the code.
>
> If that is not possible, can you link to the source so those who know
> both C++ and Fortran can take a proper look?
>

I put the C++ function here: www.dieterbritz.dk/jband.cpp
After getting errors about the extern lines, whch I had
added at the end, I shifted it to near the start:

#include <iostream>
#include <fstream>
#include <iomanip>
#include "math.h"

using namespace std;

extern "C" {

void calledFromFortran()
{ :
}

}

....

I still get errors pertaining to these lines. But after adding
the -c to the two compilation lines in the script, these are
now the only errors. I think I am getting closer. The errors
are now

jband.cpp: In function 'void calledFromFortran()':
jband.cpp:12:9: error: expected primary-expression before ':' token
12 | :
| ^
jband.cpp: At global scope:
jband.cpp:96:1: error: expected initializer before 'extern'
96 | extern "C" {
| ^~~~~~
jband.cpp:104:1: error: expected unqualified-id before '{' token
104 | {
| ^
jbandtest.f90:28:14:

28 | FORTJBAND = JBAND (tbar)
| 1
Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(10)

The last error will go away together with the others.

--
Dieter Britz

On Monday, September 11, 2023 at 3:00:26 PM UTC+3, db wrote:
> On 10.09.2023 15.22, Ben Bacarisse wrote:
> > db <dieterh...@gmail.com> writes:
> >
> >> On 09.09.2023 11.02, Mut...@dastardlyhq.com wrote:
> >>> On Sat, 9 Sep 2023 10:54:33 +0200
> >>> db <dieterh...@gmail.com> wrote:
> >>>> but now it says that C-double doesn't exist.
> >>>>
> >>>> Any ideas?
> >>> C++ mangles function names so that the name you give the function isn't
> >>> the
> >>> name the dynamic loader sees in the binary. You need to put this around whatever
> >>> function you want to call from Fortran so it has C style linkage which means
> >>> the name remains the same:
> >>> extern "C" {
> >>> void calledFromFortran()
> >>> {
> >>> :
> >>> }
> >>> }
> >>>
> >> Where should this go in the code? I added it at the end as is,
> >> and now I get this:
> >>
> >> ~/ownlib90/tests> ./jbandtest
> >> jband.cpp:88:1: error: expected initializer before 'extern'
> >> 88 | extern "C" {
> >> | ^~~~~~
> >> jband.cpp:96:1: error: expected unqualified-id before '{' token
> >> 96 | {
> >> | ^
> >> jband.cpp: In function 'void calledFromFortran()':
> >> jband.cpp:350:9: error: expected primary-expression before ':' token
> >> 350 | :
> >> ...
> >
> > You are giving people very little to go on. There's an unknown command
> > (./jbandtest) the gives some errors where only one line of code can be
> > seen.
> >
> > Can you produce a cut-down version to the program that shows the same
> > error -- mimimal example of the C++ and of the Fortran that should
> > calls it but which fails? That would mean you could post the code.
> >
> > If that is not possible, can you link to the source so those who know
> > both C++ and Fortran can take a proper look?
> >
> I put the C++ function here: www.dieterbritz.dk/jband.cpp
> After getting errors about the extern lines, whch I had
> added at the end, I shifted it to near the start:
>
> #include <iostream>
> #include <fstream>
> #include <iomanip>
> #include "math.h"
>
> using namespace std;
>
> extern "C" {
>
> void calledFromFortran()
> {
> :
> }
>
> }
>
> ...
>
> I still get errors pertaining to these lines. But after adding
> the -c to the two compilation lines in the script, these are
> now the only errors. I think I am getting closer. The errors
> are now
> jband.cpp: In function 'void calledFromFortran()':
> jband.cpp:12:9: error: expected primary-expression before ':' token
> 12 | :
> | ^
> jband.cpp: At global scope:
> jband.cpp:96:1: error: expected initializer before 'extern'
> 96 | extern "C" {
> | ^~~~~~
> jband.cpp:104:1: error: expected unqualified-id before '{' token
> 104 | {
> | ^

You have got a special talent for messing up things. :(
Please, put the code as written by your C++ specialist on your web site.
As is, without modifications!
Then we can show you where to insert ' extern "C" '.

> jbandtest.f90:28:14:
>
> 28 | FORTJBAND = JBAND (tbar)
> | 1
> Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(10)
>

FORTJBAND = real(JBAND(Real(tbar, c_long_double)), dbl)

> The last error will go away together with the others.

>
> --
> Dieter Britz

On Mon, 11 Sep 2023 14:00:06 +0200
db <dieterhansbritz@gmail.com> wrote:
>jband.cpp: In function 'void calledFromFortran()':

I told you before that calledFromFortran() was simply an example function
name I chose. I could have called it deathToTurnips(). You need to use the
prototype of the function you're going to call.

>jband.cpp:12:9: error: expected primary-expression before ':' token
> 12 | :

FFS, that was just a space to indicate code goes there, its not C++ syntax!

You need to talk to your C++ guy, your knowledge of C/C++ is clearly
non existent so its pointless you trying to do something like this which can
have many gotchas beyond simple compilation.

db <dieterhansbritz@gmail.com> writes:

> On 10.09.2023 15.22, Ben Bacarisse wrote:
>> db <dieterhansbritz@gmail.com> writes:
>>
>>> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>>>> On Sat, 9 Sep 2023 10:54:33 +0200
>>>> db <dieterhansbritz@gmail.com> wrote:
>>>>> but now it says that C-double doesn't exist.
>>>>>
>>>>> Any ideas?
>>>> C++ mangles function names so that the name you give the function isn't
>>>> the
>>>> name the dynamic loader sees in the binary. You need to put this around whatever
>>>> function you want to call from Fortran so it has C style linkage which means
>>>> the name remains the same:
>>>> extern "C" {
>>>> void calledFromFortran()
>>>> {
>>>> :
>>>> }
>>>> }
>>>>
>>> Where should this go in the code? I added it at the end as is,
>>> and now I get this:
>>>
>>> ~/ownlib90/tests> ./jbandtest
>>> jband.cpp:88:1: error: expected initializer before 'extern'
>>> 88 | extern "C" {
>>> | ^~~~~~
>>> jband.cpp:96:1: error: expected unqualified-id before '{' token
>>> 96 | {
>>> | ^
>>> jband.cpp: In function 'void calledFromFortran()':
>>> jband.cpp:350:9: error: expected primary-expression before ':' token
>>> 350 | :
>>> ...
>> You are giving people very little to go on. There's an unknown command
>> (./jbandtest) the gives some errors where only one line of code can be
>> seen.
>> Can you produce a cut-down version to the program that shows the same
>> error -- mimimal example of the C++ and of the Fortran that should
>> calls it but which fails? That would mean you could post the code.
>> If that is not possible, can you link to the source so those who know
>> both C++ and Fortran can take a proper look?
>
> I put the C++ function here: www.dieterbritz.dk/jband.cpp
> After getting errors about the extern lines, whch I had
> added at the end, I shifted it to near the start:
>
> #include <iostream>
> #include <fstream>
> #include <iomanip>
> #include "math.h"
>
> using namespace std;
>
> extern "C" {
>
> void calledFromFortran()
> {
> :
> }
>
> }

Remove them all. You have two options. One: correct the C++. To do
this put this, and only this,

extern "C" {
const long double iband(const long double tbar);
}

just after the #include lines. This is perfect (the first const is a
meaningless word here and the compiler may warn you about that) but it
will do.

Next replace

#include "math.h"

with

#include <math.h>

I'd also remove the two unnecessary #include lines (for iomanip and
fstream). All of these are "tidying up". Only the extern "C" part I
gave corrects an actual mistake.

The second option is the turn the code in C which links directly with
Fortran. The only C++ used by the code is one "cout << " line (not a
good way to report an error, but that's not important right now) and a
setting for pi that is not a compile-time constant (4*atanl(1)) written
in a more fussy way.

To convert to C, copy the file to jband.c (rather than .cpp) and replce
the declaration for pi. Given the code is littered with explicit 21
digits decimals (a little more than the precision of C's usualy long
double type) I would just write

static const long double pi = 3.14159265358979323846L;

Now replace the cout line with

fputs("\nError in stredges::iband(): tbar must be > 0", stderr);

This writes the message to the error stream and put only these two
include lines at the top:

#include <math.h>
#include <stdio.h>

Now the file is C code.

Frankly, this is the way I'd go, since linking C is just that bit
simpler than linking C++. But if the code is going to become fully
fledged (and complex) C++, obviously use my first option.

> I still get errors pertaining to these lines. But after adding
> the -c to the two compilation lines in the script, these are
> now the only errors. I think I am getting closer. The errors
> are now

Yes, you must compile it like this:

g++ -c jband.cpp (for C++ code)
gcc -c jband.c (for C code)

You don't need any -o but you could add in lots of warnings like

gcc -Wall -Wextra -c jband.c

> jband.cpp: In function 'void calledFromFortran()':
> jband.cpp:12:9: error: expected primary-expression before ':' token
> 12 | :
> | ^
> jband.cpp: At global scope:
> jband.cpp:96:1: error: expected initializer before 'extern'
> 96 | extern "C" {
> | ^~~~~~
> jband.cpp:104:1: error: expected unqualified-id before '{' token
> 104 | {
> | ^
> jbandtest.f90:28:14:
>
> 28 | FORTJBAND = JBAND (tbar)
> | 1
> Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(10)
>
> The last error will go away together with the others.

Michael S has given you one way to go for that. My comments were going
to be more general. You have several ways of specifying the types, and
I could not tell if you really wanted all of them. In general, I would
define the Fortran types from the C ones (since those are the types you
need for the call and return) and leave it at that.

But the big one is that the Fortran code seems to think the function is
called jband, when in fact it's called iband.

I went for this:

module STUFF
use iso_c_binding
integer, parameter :: qud=real(c_long_double)
end module STUFF
program JBAND_TEST
use STUFF; implicit none
real(qud) :: tbar, curr, FORTJBAND
do
read *, tbar
if (tbar < 0) exit
curr = FORTJBAND (tbar)
print '(" curr =", f10.4)', curr
enddo
end program JBAND_TEST

function FORTJBAND (tbar)
use STUFF; implicit none
interface
function IBAND (tbar) bind(c)
use STUFF
real(qud), VALUE :: tbar
real(qud) :: IBAND
end function iband
end interface
real(qud) :: FORTJBAND, tbar
FORTJBAND = IBAND(tbar)
end function FORTJBAND

Note that you can compile the Fortran along with the C at the same time
if you like:

$ gfortran -o jtest jbandtest.f90 jband.c -lm
$ ./jtest
1 curr = 1.5224
1e-10
curr =56419.9584
-1
$

($ is my Linux command-line prompt). I have no idea if these are
correct results and I can't be sure what you need to run on your system,
but the code links and appears to work.

If you go with the C++ option, the linking needs the standard C++
library:

$ gfortran -o jtest jbandtest.f90 jband.cpp -lstdc++ -lm
$ ./jtest
1 curr = 1.5224
1e-10
curr =56419.9584
-1
$

BTW, you said the C++ was written by a C++ expert. I don't think it
was!

--
Ben.

On 12.09.2023 01.26, Ben Bacarisse wrote:
> db <dieterhansbritz@gmail.com> writes:
>
>> On 10.09.2023 15.22, Ben Bacarisse wrote:
>>> db <dieterhansbritz@gmail.com> writes:
>>>
>>>> On 09.09.2023 11.02, Muttley@dastardlyhq.com wrote:
>>>>> On Sat, 9 Sep 2023 10:54:33 +0200
>>>>> db <dieterhansbritz@gmail.com> wrote:
>>>>>> but now it says that C-double doesn't exist.
>>>>>>
>>>>>> Any ideas?
>>>>> C++ mangles function names so that the name you give the function isn't
>>>>> the
>>>>> name the dynamic loader sees in the binary. You need to put this around whatever
>>>>> function you want to call from Fortran so it has C style linkage which means
>>>>> the name remains the same:
>>>>> extern "C" {
>>>>> void calledFromFortran()
>>>>> {
>>>>> :
>>>>> }
>>>>> }
>>>>>
>>>> Where should this go in the code? I added it at the end as is,
>>>> and now I get this:
>>>>
>>>> ~/ownlib90/tests> ./jbandtest
>>>> jband.cpp:88:1: error: expected initializer before 'extern'
>>>> 88 | extern "C" {
>>>> | ^~~~~~
>>>> jband.cpp:96:1: error: expected unqualified-id before '{' token
>>>> 96 | {
>>>> | ^
>>>> jband.cpp: In function 'void calledFromFortran()':
>>>> jband.cpp:350:9: error: expected primary-expression before ':' token
>>>> 350 | :
>>>> ...
>>> You are giving people very little to go on. There's an unknown command
>>> (./jbandtest) the gives some errors where only one line of code can be
>>> seen.
>>> Can you produce a cut-down version to the program that shows the same
>>> error -- mimimal example of the C++ and of the Fortran that should
>>> calls it but which fails? That would mean you could post the code.
>>> If that is not possible, can you link to the source so those who know
>>> both C++ and Fortran can take a proper look?
>>
>> I put the C++ function here: www.dieterbritz.dk/jband.cpp
>> After getting errors about the extern lines, whch I had
>> added at the end, I shifted it to near the start:
>>
>> #include <iostream>
>> #include <fstream>
>> #include <iomanip>
>> #include "math.h"
>>
>> using namespace std;
>>
>> extern "C" {
>>
>> void calledFromFortran()
>> {
>> :
>> }
>>
>> }
>
> Remove them all. You have two options. One: correct the C++. To do
> this put this, and only this,
>
> extern "C" {
> const long double iband(const long double tbar);
> }
>
> just after the #include lines. This is perfect (the first const is a
> meaningless word here and the compiler may warn you about that) but it
> will do.
>
> Next replace
>
> #include "math.h"
>
> with
>
> #include <math.h>
>
> I'd also remove the two unnecessary #include lines (for iomanip and
> fstream). All of these are "tidying up". Only the extern "C" part I
> gave corrects an actual mistake.
>
> The second option is the turn the code in C which links directly with
> Fortran. The only C++ used by the code is one "cout << " line (not a
> good way to report an error, but that's not important right now) and a
> setting for pi that is not a compile-time constant (4*atanl(1)) written
> in a more fussy way.
>
> To convert to C, copy the file to jband.c (rather than .cpp) and replce
> the declaration for pi. Given the code is littered with explicit 21
> digits decimals (a little more than the precision of C's usualy long
> double type) I would just write
>
> static const long double pi = 3.14159265358979323846L;
>
> Now replace the cout line with
>
> fputs("\nError in stredges::iband(): tbar must be > 0", stderr);
>
> This writes the message to the error stream and put only these two
> include lines at the top:
>
> #include <math.h>
> #include <stdio.h>
>
> Now the file is C code.
>
> Frankly, this is the way I'd go, since linking C is just that bit
> simpler than linking C++. But if the code is going to become fully
> fledged (and complex) C++, obviously use my first option.
>
>> I still get errors pertaining to these lines. But after adding
>> the -c to the two compilation lines in the script, these are
>> now the only errors. I think I am getting closer. The errors
>> are now
>
> Yes, you must compile it like this:
>
> g++ -c jband.cpp (for C++ code)
> gcc -c jband.c (for C code)
>
> You don't need any -o but you could add in lots of warnings like
>
> gcc -Wall -Wextra -c jband.c
>
>> jband.cpp: In function 'void calledFromFortran()':
>> jband.cpp:12:9: error: expected primary-expression before ':' token
>> 12 | :
>> | ^
>> jband.cpp: At global scope:
>> jband.cpp:96:1: error: expected initializer before 'extern'
>> 96 | extern "C" {
>> | ^~~~~~
>> jband.cpp:104:1: error: expected unqualified-id before '{' token
>> 104 | {
>> | ^
>> jbandtest.f90:28:14:
>>
>> 28 | FORTJBAND = JBAND (tbar)
>> | 1
>> Error: Type mismatch in argument 'tbar' at (1); passed REAL(16) to REAL(10)
>>
>> The last error will go away together with the others.
>
> Michael S has given you one way to go for that. My comments were going
> to be more general. You have several ways of specifying the types, and
> I could not tell if you really wanted all of them. In general, I would
> define the Fortran types from the C ones (since those are the types you
> need for the call and return) and leave it at that.
>
> But the big one is that the Fortran code seems to think the function is
> called jband, when in fact it's called iband.
>
> I went for this:
>
> module STUFF
> use iso_c_binding
> integer, parameter :: qud=real(c_long_double)
> end module STUFF
> program JBAND_TEST
> use STUFF; implicit none
> real(qud) :: tbar, curr, FORTJBAND
> do
> read *, tbar
> if (tbar < 0) exit
> curr = FORTJBAND (tbar)
> print '(" curr =", f10.4)', curr
> enddo
> end program JBAND_TEST
>
> function FORTJBAND (tbar)
> use STUFF; implicit none
> interface
> function IBAND (tbar) bind(c)
> use STUFF
> real(qud), VALUE :: tbar
> real(qud) :: IBAND
> end function iband
> end interface
> real(qud) :: FORTJBAND, tbar
> FORTJBAND = IBAND(tbar)
> end function FORTJBAND
>
> Note that you can compile the Fortran along with the C at the same time
> if you like:
>
> $ gfortran -o jtest jbandtest.f90 jband.c -lm
> $ ./jtest
> 1
> curr = 1.5224
> 1e-10
> curr =56419.9584
> -1
> $
>
> ($ is my Linux command-line prompt). I have no idea if these are
> correct results and I can't be sure what you need to run on your system,
> but the code links and appears to work.
>
> If you go with the C++ option, the linking needs the standard C++
> library:
>
> $ gfortran -o jtest jbandtest.f90 jband.cpp -lstdc++ -lm
> $ ./jtest
> 1
> curr = 1.5224
> 1e-10
> curr =56419.9584
> -1
> $
>
> BTW, you said the C++ was written by a C++ expert. I don't think it
> was!
>
The code, apart from the extra lines suggested by someone here,
but without the information on where to put them, is runnable
C++ code written by another person who knows C++ very well. I
myself use Fortran and you are right, I know next to nothing
about C++. I did use the extra code exactly as is, but possibly
put it in the wrong place. I tried two, without success.
I am giving up, and will translate the C++ function into Fortran,
where I know what I'm doing.
--
Dieter Britz