Rocksolid Light

Welcome to RetroBBS

mail  files  register  newsreader  groups  login

Message-ID:  

Authentic: Indubitably true, in somebody's opinion.

dovenet / Synchronet Programming / DDMsgReader: When viewing message headers, now shows all available mes

SubjectAuthor
o DDMsgReader: When viewing message headers, now shows all available mesRob Swindell

1
DDMsgReader: When viewing message headers, now shows all available mes

<6448A26B.46971.syncprog@vert.synchro.net>

  copy mid

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=972&group=DOVE-Net.Synchronet_Programming#972

  copy link   Newsgroups: DOVE-Net.Synchronet_Programming
From: rob.swindell@VERT (Rob Swindell)
To: GitLab note in main/sbbs
Subject: DDMsgReader: When viewing message headers, now shows all available mes
Message-ID: <6448A26B.46971.syncprog@vert.synchro.net>
Date: Tue, 25 Apr 2023 21:02:51 -0700
X-Comment-To: GitLab note in main/sbbs
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/fcf4a0012 Apr 4 2023 GCC 12.2.0
X-FTN-MSGID: 46971.syncprog@1:103/705 28ae8fe6
X-FTN-CHRS: CP437 2
WhenImported: 20230425210251-0700 c1e0
WhenExported: 20230426032646-0700 c1e0
ExportedFrom: VERT syncprog 46971
Content-Type: text/plain; charset=IBM437
Content-Transfer-Encoding: 8bit
 by: Rob Swindell - Wed, 26 Apr 2023 04:02 UTC

https://gitlab.synchro.net/main/sbbs/-/merge_requests/288#note_3503

What is the purpose of this (gSMBDefsLoaded)? It doesn't appear to be used anywhere.

require() already does the necessary optimization. Checking for file existence seems unnecessary and a slight performance hit. Have you seen this example design pattern in any other exec/*.js files?

Just move the `require("smbdefs.js", "SMB_POLL_ANSWER");` out of the condition and you'll be good to go.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

dovenet / Synchronet Programming / DDMsgReader: When viewing message headers, now shows all available mes

1
server_pubkey.txt

rocksolid light 0.9.81
clearnet tor