RetroBBS - DOVE-Net.Synchronet_Programming - New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<64203cf5d02a9_16665a2ab6943ef998510bb@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=809&group=DOVE-Net.Synchronet_Programming#809

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <64203cf5d02a9_16665a2ab6943ef998510bb@prd-scan-dashboard-0.mail>
Date: Sun, 26 Mar 2023 05:39:18 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/5ba5d97ac Mar 18 2023 GCC 12.2.0
X-FTN-MSGID: 46808.syncprog@1:103/705 288629d0
X-FTN-CHRS: CP437 2
WhenImported: 20230326053920-0700 c1e0
WhenExported: 20230326111805-0700 c1e0
ExportedFrom: VERT syncprog 46808
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on git.synchro.net
X-Spam-Level:
X-Spam-Status: No, score=0.9 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,SENDGRID_REDIR autolearn=no autolearn_force=no
version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=8URyivg0esWOx6B5vtOPDSDlgcVBCk94IHqjO1+dNi8=;
b=ZXDsPEpkjKuZ2D2fkEASqPueYLqDokuuWA3RWbGg38uA/7hJVRbM3Ne9kJxQOfEiZPAX
YvuZfq3WHmB+bfbGZURO2kVcmsVZUSrXfFqgS/J8zdpe7xTSWtjTpwUWBaIPYR6Be6hfis
nPbAo4EtNwM1gYZV5szzfzdgorOyo38/m2LoI+ZgrICvEBnF63q9RZ8uTCLdkGDkT3lJPq
20A2fHYmSU6QkBvQqHph0TS1ZTJLL/zsXXJNZK+MLtHWh6rI21g2E3swWJVruy5rqNQxHF
+A7SuxpKy5P2SInyZQMEbzPFVRJz4WZ9btbxxysTRNqVOMODhjwVDQ2tA/11y52g==
Mime-Version: 1.0
X-SG-EID:
HBOmY/E5MTYb8Mhr7ulQJIaFxcZEWpCD/7YwgOg+H8sEkVXiXr3stBpE0zKCnS
EZ7AsdEPCW/P49XK9N3tPQeEKX7YdMVi4/cIVHG
vmgYZbBJIXl2ixYEjG+KpH5BjIBii83NW7eF6OP
XFaByrQi9li94tgUPxN/GRKJqtgH3Lr1rHbVYLI
+nVV/tkVqgidoQ4Kz7VwVpiYv/TalaHkuyQ==
X-Entity-ID: S2cgcZKcMUFZg9Mweglhkg==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Sun, 26 Mar 2023 05:39 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)

** CID 451057: Uninitialized variables (UNINIT)
/tmp/sbbs-Mar-26-2023/src/uifc/uifcx.c: 218 in ulist()

________________________________________________________________________________________________________
*** CID 451057: Uninitialized variables (UNINIT)
/tmp/sbbs-Mar-26-2023/src/uifc/uifcx.c: 218 in ulist()
212 cur = &tmpcur;
213
214 for(opts=0;opts<MAX_OPTS;opts++)
215 if(option[opts]==NULL || option[opts][0]==0)
216 break;
217
>>> CID 451057: Uninitialized variables (UNINIT)
>>> Using uninitialized value "*cur".
218 if((*cur)>=opts)
219 (*cur)=opts-1; /* returned after scrolled */
220
221 if((*cur)<0)
222 (*cur)=0;
223

** CID 451056: Error handling issues (CHECKED_RETURN)
/umonitor/umonitor.c: 872 in main()

________________________________________________________________________________________________________
*** CID 451056: Error handling issues (CHECKED_RETURN)
/umonitor/umonitor.c: 872 in main()
866 );
867
868 /* close .ini file here */
869 if(fp!=NULL)
870 fclose(fp);
871
>>> CID 451056: Error handling issues (CHECKED_RETURN)
>>> Calling "chdir" without checking return value (as is done elsewhere 18 out of 21 times).
872 chdir(bbs_startup.ctrl_dir);
873
874 /* Read .cfg files here */
875 memset(&cfg,0,sizeof(cfg));
876 cfg.size=sizeof(cfg);
877 SAFECOPY(cfg.ctrl_dir,bbs_startup.ctrl_dir);

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DQ4kK_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDg36x62girPn1zYBhcccXwhYdDfdMRepLksuDfaAvd4bat4-2FUDdrJDqZKFgkT5rhTEpd1i-2F-2F-2Bt12VuLwisIe8fgC5UgDGF2gzRbivh2YT2HQfxF8BKGqVwBOdsLqq8RDB0gsCQJzB5reNTbkfkMIUprGduJhT4EnW8bblt9BSyQw-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

I may not be able to walk, but I drive from a sitting position.

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com