RetroBBS - DOVE-Net.Synchronet_Programming - New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<64049d822d6df_154822ac76c8fd9b01651f@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=723&group=DOVE-Net.Synchronet_Programming#723

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <64049d822d6df_154822ac76c8fd9b01651f@prd-scan-dashboard-0.mail>
Date: Sun, 5 Mar 2023 06:47:46 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/5d1d586fd Mar 3 2023 GCC 12.2.0
X-FTN-MSGID: 46722.syncprog@1:103/705 286a8a25
X-FTN-CHRS: CP437 2
WhenImported: 20230305054819-0800 41e0
WhenExported: 20230305161814-0800 41e0
ExportedFrom: VERT syncprog 46722
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on git.synchro.net
X-Spam-Level:
X-Spam-Status: No, score=0.9 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,SENDGRID_REDIR autolearn=no autolearn_force=no
version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=hIsc60H+wrgDVKwwqBVrkgaoDydGa6y/WfJcj6wBtR4=;
b=GSEReY2KtXgcOnkkznMeWL6s4G5dEgFcxKCt34O2apHQnFhrsDZ9UA+Bi3nnNcg8CjWU
YjPQUyr6CbnWJcjnUt8cbBdEHPh/Z4vcN7Wy9JtfifnN0uUVhTdrV2HodCEZj9Wq++QJnx
yfS4qsLdUlzdrenAn9dH5Di/BRjvNym+bARzbqwUnvocagX23z1wYhzuKDcVi/GUj/Sm5c
Sq8IsRe4vQTMJvORrp9Yv3jHPJGKpYUj/zpFngG6KuZCkjL+tPoaGIGwRhtB9JdhwGT0vF
eD9cMsFLYKrnCqIGSUUYTf1bxVQxbceHtLpGhqpk9UotgwC+Px90Cq4+zI4ZNOQw==
Mime-Version: 1.0
X-SG-EID:
HBOmY/E5MTYb8Mhr7ulQJIaFxcZEWpCD/7YwgOg+H8vlq+yiESboSSCxffN4++
c8ItgxSg1OtIybPUCdagZPjuOubKNRCCDWH5OKy
UghT+oeddL24T/u0yTdhMCn30OXISLY5QWtkRhl
BMsdaHjlT10Y9VFb4KcLo+bE5VYENqgMvCK6dSx
DiYgRxz6kkfYiukc2IBSjvg4Ro9EaEqsJwg==
X-Entity-ID: S2cgcZKcMUFZg9Mweglhkg==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Sun, 5 Mar 2023 06:47 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)

** CID 446269: Error handling issues (CHECKED_RETURN)
/download.cpp: 118 in sbbs_t::protocol(prot_t *, XFER_TYPE, const char *, const char *, bool, bool, long *)()

________________________________________________________________________________________________________
*** CID 446269: Error handling issues (CHECKED_RETURN)
/download.cpp: 118 in sbbs_t::protocol(prot_t *, XFER_TYPE, const char *, const char *, bool, bool, long *)()
112 char msg[256];
113 int i;
114 long ex_mode;
115 FILE* stream;
116
117 SAFEPRINTF(protlog,"%sPROTOCOL.LOG",cfg.node_dir);
>>> CID 446269: Error handling issues (CHECKED_RETURN)
>>> Calling "remove(protlog)" without checking return value. This library function may fail and return an error code.
118 remove(protlog); /* Deletes the protocol log */
119 autohang=false;
120 if(autohangup) {
121 if(useron.misc&AUTOHANG)
122 autohang=true;
123 else if(text[HangUpAfterXferQ][0])

** CID 446268: High impact quality (Y2K38_SAFETY)
/download.cpp: 75 in sbbs_t::notdownloaded(long, long)()

________________________________________________________________________________________________________
*** CID 446268: High impact quality (Y2K38_SAFETY)
/download.cpp: 75 in sbbs_t::notdownloaded(long, long)()
69 /****************************************************************************/
70 void sbbs_t::notdownloaded(off_t size, time_t elapsed)
71 {
72 char str[256],tmp2[256];
73 char tmp[512];
74
>>> CID 446268: High impact quality (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "elapsed" is cast to "uint".
75 SAFEPRINTF2(str,"Estimated Time: %s Transfer Time: %s"
76 ,sectostr(cur_cps ? (uint)(size/cur_cps) : 0,tmp)
77 ,sectostr((uint)(elapsed),tmp2));
78 logline(nulstr,str);
79 if(cfg.leech_pct && cur_cps /* leech detection */
80 && elapsed>=cfg.leech_sec

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3D0CIb_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDsLibgv2fl5LZs5fAQNGsZiCzF58zgFnZOT-2BlAwIBwcfoIFtkbk55EV3j6VxmkZw2I9Fj-2BLI35zSUrIN0KShaRGuiHzricb5Wsx-2BB-2BhnhGtOrWPGOz2109TMcJgLBqc5aFWaJOutaTnzR1bYeWA4E8s00cQ8HSd2ZyQUokgP9TtQ-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

If little else, the brain is an educational toy. -- Tom Robbins

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com