Message-ID:

Hey, wait a minute!! I want a divorce!! ... you're not Clint Eastwood!!

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<63d7c7e0446b3_abfb02abb08c1f99c899aa@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=435&group=DOVE-Net.Synchronet_Programming#435

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <63d7c7e0446b3_abfb02abb08c1f99c899aa@prd-scan-dashboard-0.mail>
Date: Mon, 30 Jan 2023 06:36:32 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/01f21bdcc Jan 29 2023 GCC 12.2.0
X-FTN-MSGID: 46428.syncprog@1:103/705 283db343
X-FTN-CHRS: CP437 2
WhenImported: 20230130053639-0800 41e0
WhenExported: 20230130101819-0800 41e0
ExportedFrom: VERT syncprog 46428
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on git.synchro.net
X-Spam-Level:
X-Spam-Status: No, score=0.9 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,SENDGRID_REDIR autolearn=no autolearn_force=no
version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=Ow2AVFnK0NsvIVQtxteR3UOrmllST6lhYf8ztfsYwmg=;
b=ebfEi/zelLqEku/r5RJ7Ea9JIY++MHti6j+ISXe4T6N073+aTQk0Ex3aotLTHs3BEYNS
sCUba7+PK0NAtwxSJ/6avk899s0S1GdbIqk+95yhojFI2MYB7aZlC854UjPHnY9wl/O2bZ
Fd0+A0+414kfWDXdtPiB+bPS5qBaZyiZla3pi6uyjJWYCeRM7728uE9jH0w87knSGLz3F1
Ml5cchMuDPl+7Tezg3FxsTLrb2jN8N3JdXQPtEAlm4XyuyIx46B7uWaMR6/Egl4j+sOwKc
m8H8wRPDjbBXWzNRluXp5hNTvLSiROSBjZPanXnYvXJS92fhjD3NzXHYFJq47m0g==
Mime-Version: 1.0
X-SG-EID:
HBOmY/E5MTYb8Mhr7ulQJIaFxcZEWpCD/7YwgOg+H8u99X2szDwxYLPZ4ApIsH
kjzm7xEL6dTLR1//KNwkTpTtN7cnIaUuUlV7vb6
dPJv5eQ0C1NgwGOA6Q2iZYNAcXeghnoXlLxL2Gk
EztcZfuYUiYWoSPFW+9/cV42OLk9KAdTzmpaxzu
qEhu52m8uo8D7LuXOPMOEx06zgYWxrVmBfA==
X-Entity-ID: S2cgcZKcMUFZg9Mweglhkg==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Mon, 30 Jan 2023 06:36 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)

** CID 435652: High impact quality (Y2K38_SAFETY)
/logfile.cpp: 46 in hacklog()

________________________________________________________________________________________________________
*** CID 435652: High impact quality (Y2K38_SAFETY)
/logfile.cpp: 46 in hacklog()
40 return false;
41
42 inet_addrtop(addr, ip, sizeof(ip));
43 fprintf(fp,"SUSPECTED %s HACK ATTEMPT for user '%s' on %.24s%sUsing port %u at %s [%s]%s"
44 ,prot
45 ,user
>>> CID 435652: High impact quality (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "now" is cast to "time32_t".
46 ,timestr(cfg, (time32_t)now, tstr)
47 ,log_line_ending
48 ,inet_addrport(addr)
49 ,host
50 ,ip
51 ,log_line_ending

** CID 435651: High impact quality (Y2K38_SAFETY)
/logfile.cpp: 102 in spamlog()

________________________________________________________________________________________________________
*** CID 435651: High impact quality (Y2K38_SAFETY)
/logfile.cpp: 102 in spamlog()
96 if(from==NULL)
97 from=host;
98
99 fprintf(fp, "SUSPECTED %s SPAM %s on %.24s%sHost: %s [%s]%sFrom: %.128s %s%s"
100 ,prot
101 ,action
>>> CID 435651: High impact quality (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "now" is cast to "time32_t".
102 ,timestr(cfg, (time32_t)now, tstr)
103 ,log_line_ending
104 ,host
105 ,ip_addr
106 ,log_line_ending
107 ,from

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DrmwL_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrD1h-2BJFDuaPIzN3MjUxXvYYHQg-2Fq-2FfU-2Fa0iL0wmBIUr-2BFn-2Bh5d5qL-2FdY2FQedxymvZp-2Fl55lN-2BSO3rsaz-2BpIvPpEo8wZX8gGIoIufwknwcoNkG-2FC8e4PiByeZMHapM18xVRoUJvvlaXk0sHvmcwKAwJTorTghaXM6HlUMk6GBouCg-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com