RetroBBS - DOVE-Net.Synchronet_Programming

src/sbbs3/main.cpp sbbs.h

<6615E545.49464.syncprog@vert.synchro.net>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=3478&group=DOVE-Net.Synchronet_Programming#3478

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: rob.swindell.(on.windows.11)@VERT (Rob Swindell (on Windows 11))
To: Git commit to main/sbbs/master
Subject: src/sbbs3/main.cpp sbbs.h
Message-ID: <6615E545.49464.syncprog@vert.synchro.net>
Date: Tue, 9 Apr 2024 18:03:01 -0700
X-Comment-To: Git commit to main/sbbs/master
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/f2a017ec6 Mar 24 202 GCC 12.2.0
X-FTN-MSGID: 49464.syncprog@1:103/705 2a7bdc7d
X-FTN-CHRS: UTF-8 4
WhenImported: 20240409180301-0700 c1e0
WhenExported: 20240411085063-0700 c1e0
ExportedFrom: VERT syncprog 49464
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

by: Rob Swindell (on Win - Wed, 10 Apr 2024 01:03 UTC

https://gitlab.synchro.net/main/sbbs/-/commit/221507a8d36e31306b0e9a6d
Modified Files:
src/sbbs3/main.cpp sbbs.h
Log Message:
Reduce the Terminal Server thread outcom timeout from 80 seconds to 800 ms

Since the Terminal Server is a single thread, let's not block for long
periods of time trying to send bytes to a client (e.g. send the badip.msg
file contents to a client with a blocked IP address), effectively DoSing the
terminal server.

This should address the problem reported via IRC:
<theviper4> �Apr 9 15:38:11 viper-bbs synchronet: term Terminal Server timeout(outcom) 0000 0000
<theviper4> �Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 110 sending on socket 39
<theviper4> �Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
<theviper4> �Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
<theviper4> �Apr 9 15:38:36 viper-bbs synchronet: term 0039 Telnet !CLIENT BLOCKED in ip.can: 117.95.153.33

Also, make the outcom timeout error message more helpful (e.g. include the
sock descriptor of the client) and don't use the old rioctl() function
here any more.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Charity begins at home. -- Publius Terentius Afer (Terence)

dovenet / Synchronet Programming / src/sbbs3/main.cpp sbbs.h

Subject	Author
src/sbbs3/main.cpp sbbs.h	Rob Swindell (on Windows 11)