Message-ID:

7 May, 2024: fms is rebuilding. Don't expect much in that section for quite a few days, maybe longer.

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<6615406eca1b8_730a12bc2fbf579b0568fc@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=3475&group=DOVE-Net.Synchronet_Programming#3475

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <6615406eca1b8_730a12bc2fbf579b0568fc@prd-scan-dashboard-0.mail>
Date: Tue, 9 Apr 2024 13:19:43 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/8108e0cd9 Apr 08 202 GCC 12.2.0
X-FTN-MSGID: 49461.syncprog@1:103/705 2a7b37a5
X-FTN-CHRS: CP437 2
WhenImported: 20240409061944-0700 c1e0
WhenExported: 20240411085063-0700 c1e0
ExportedFrom: VERT syncprog 49461
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on git.synchro.net
X-Spam-Level:
X-Spam-Status: No, score=-0.1 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS autolearn=unavailable autolearn_force=no
version=4.0.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=aQDb4WYxBxzDwxdWrnX6dwpcm67rsfYJTcPCdTFaj54=;
b=B1hzFtfq6L66bR1/frIPIsT67ID3mewOs6urOaY6AXi54jsHv+dgjN4ezoOI3/ckVYFF
r8nARKmVBpL7j9aqIiA/BYJ13jGzvCWby8hRccHIazX47a8FNo60+I3ODeBlbCJ27f5kNN
QR6D9rg3qo1mGn1LNFN7APV4F82uZOX7gCfUFbNy6jaV0ITVPO+d9MBg+7ntA8olFaPo2z
omZCy/HAjqo/aGiZSTNjCRxOIuGFHKVj2oL4cu+ZKJNzc2dsCUUvFBpT0N8eDlzO2zmL/8
shjekGfj1JuS0/AfiILSePZpdPor08565TztjbGYzShuV/6r3r/Qo7iNTjjsg8xA==
Mime-Version: 1.0
X-SG-EID:
u001.bI5ZkLckHgS1uX/uew1xm7Gqyoa0IpDnCcvbX7VNNtmOiIAr5ngTZOrE3
K+xiuTb6wd+ocactSDBujjnf9F6QI6tXUa003EU
P8bsEGgzqj+QgcD776d7aiqgtcnCEpB+lRDRX3W
FgUITyps1Yr8BWxGXmbtfjU0UOTSdfg0d9F2D0c
m/bvNVc/Xcqvvg1jsQCbHI2HHWULyRJaoL61dMl
A==
X-Entity-ID: u001.Q1a3p5tGdkqpaJEACGou+w==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Tue, 9 Apr 2024 13:19 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 492287: Error handling issues (CHECKED_RETURN)
/main.cpp: 4472 in node_thread(void *)()

________________________________________________________________________________________________________
*** CID 492287: Error handling issues (CHECKED_RETURN)
/main.cpp: 4472 in node_thread(void *)()
4466 }
4467 SAFEPRINTF2(str,"%s%s.bin",sbbs->cfg.mods_dir
4468 ,sbbs->cfg.shell[sbbs->useron.shell]->code);
4469 if(sbbs->cfg.mods_dir[0]==0 || !fexistcase(str)) {
4470 SAFEPRINTF2(str,"%s%s.bin",sbbs->cfg.exec_dir
4471 ,sbbs->cfg.shell[sbbs->useron.shell]->code);
>>> CID 492287: Error handling issues (CHECKED_RETURN)
>>> Calling "fexistcase" without checking return value (as is done elsewhere 117 out of 131 times).
4472 fexistcase(str);
4473 }
4474 if((file=sbbs->nopen(str,O_RDONLY))==-1) {
4475 sbbs->errormsg(WHERE,ERR_OPEN,str,O_RDONLY);
4476 sbbs->hangup();
4477 break;

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3DHvP9_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQagYisv-2BW69zRWxBhimCtdag5Y-2FmNQU-2F9a-2BQz99muYyDMQHaJ9IAAUHt0J4m9PdQ-2FM2LeT5-2B1UNdpeKXpgNOTn265LNUeBHOZI40IJ3EqY58uotyMvBntmOFa6NssYuPj9pyF9jsG3Ot15K77yZ8uUVZ5aWBxVVnDKUwxo1ITxjHQ-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com