Rocksolid Light

Welcome to RetroBBS

mail  files  register  newsreader  groups  login

Message-ID:  

Wagner's music is better than it sounds. -- Mark Twain


dovenet / Synchronet Programming / src/sbbs3/logout.cpp sbbs.h

SubjectAuthor
o src/sbbs3/logout.cpp sbbs.hRob Swindell (on Windows 11)

1
src/sbbs3/logout.cpp sbbs.h

<65FF6FCB.49390.syncprog@vert.synchro.net>

  copy mid

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=3407&group=DOVE-Net.Synchronet_Programming#3407

  copy link   Newsgroups: DOVE-Net.Synchronet_Programming
From: rob.swindell.(on.windows.11)@VERT (Rob Swindell (on Windows 11))
To: Git commit to main/sbbs/master
Subject: src/sbbs3/logout.cpp sbbs.h
Message-ID: <65FF6FCB.49390.syncprog@vert.synchro.net>
Date: Sat, 23 Mar 2024 17:11:55 -0700
X-Comment-To: Git commit to main/sbbs/master
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/c3e46719e Mar 2 2024 GCC 12.2.0
X-FTN-MSGID: 49390.syncprog@1:103/705 2a6566b9
X-FTN-CHRS: CP437 2
WhenImported: 20240323171155-0700 c1e0
WhenExported: 20240329040315-0700 c1e0
ExportedFrom: VERT syncprog 49390
Content-Type: text/plain; charset=IBM437
Content-Transfer-Encoding: 8bit
 by: Rob Swindell (on Win - Sun, 24 Mar 2024 00:11 UTC

https://gitlab.synchro.net/main/sbbs/-/commit/b8e2c8526f154228d54d16a8
Modified Files:
src/sbbs3/logout.cpp sbbs.h
Log Message:
Add/use sbbs_t::fremove() to remove files with logged error on failure

This should resolve CID 487088: Unchecked return value from library
as well as add some more instrumentation upon unexpected failures removing
files.

Consider: do some callers of this function need to know the success status
(return bool)? That then starts to get into the some callers check and some
don't situation (Coverity issue). For now, this is a void function.

Also, all remove failures are logged as errors. Consider possibly passing
a log level and calling lprintf() instead of errormsg(). errormsg() displays
a notice to the user, which maybe we don't want.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

1
server_pubkey.txt

rocksolid light 0.9.81
clearnet tor