Message-ID:

7 May, 2024: fms is rebuilding. Don't expect much in that section for quite a few days, maybe longer.

dovenet / Synchronet Programming / src/sbbs3/sauce.c

src/sbbs3/sauce.c

<65FF61D0.49386.syncprog@vert.synchro.net>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=3403&group=DOVE-Net.Synchronet_Programming#3403

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: rob.swindell.(on.windows.11)@VERT (Rob Swindell (on Windows 11))
To: Git commit to main/sbbs/master
Subject: src/sbbs3/sauce.c
Message-ID: <65FF61D0.49386.syncprog@vert.synchro.net>
Date: Sat, 23 Mar 2024 16:12:16 -0700
X-Comment-To: Git commit to main/sbbs/master
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/c3e46719e Mar 2 2024 GCC 12.2.0
X-FTN-MSGID: 49386.syncprog@1:103/705 2a6558ba
X-FTN-CHRS: CP437 2
WhenImported: 20240323161216-0700 c1e0
WhenExported: 20240329040315-0700 c1e0
ExportedFrom: VERT syncprog 49386
Content-Type: text/plain; charset=IBM437
Content-Transfer-Encoding: 8bit

by: Rob Swindell (on Win - Sat, 23 Mar 2024 23:12 UTC

https://gitlab.synchro.net/main/sbbs/-/commit/c8634c7adc3633923d5db58f
Modified Files:
src/sbbs3/sauce.c
Log Message:
SAFECOPY (now using strlcpy) requires the source is terminated

.... so use strncpy() and TERMINATE() here (instead of SAFECOPY) to resolve
newly reported Coverity issues.

There may be other places where we're using SAFECOPY() with an unterminated
source string that would've been fine before we switched SAFECOPY from using
strncpy to strlcpy. So we should reconsider that change.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

Subject	Author
src/sbbs3/sauce.c	Rob Swindell (on Windows 11)