RetroBBS - DOVE-Net.Synchronet_Programming - New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<65f991a532c78_3cd7252d9e6d4b399c153fb@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=3317&group=DOVE-Net.Synchronet_Programming#3317

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <65f991a532c78_3cd7252d9e6d4b399c153fb@prd-scan-dashboard-0.mail>
Date: Tue, 19 Mar 2024 13:22:45 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/52afd2408 Mar 11 202 GCC 12.2.0
X-FTN-MSGID: 49299.syncprog@1:103/705 2a5f8839
X-FTN-CHRS: CP437 2
WhenImported: 20240319062246-0700 c1e0
WhenExported: 20240329040315-0700 c1e0
ExportedFrom: VERT syncprog 49299
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on git.synchro.net
X-Spam-Level:
X-Spam-Status: No, score=-0.1 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
autolearn_force=no version=4.0.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=4tsLluQl1eaGVMOw+xoqNXcqnQKQKwt55FEVIdzdKPo=;
b=Oa1yqX1C0cM4xmjXJj/hkhp4B+ZgpOXKtPUqKHy/sRlJkHe4ecePC0DMlMBdYMK8/4KL
pXJ5KbUpLEqHLasNxOnjmhbL3Nt1cFt0BZ/5ufQhwSPiq82uL5AGddpFmBxUxD21EOAXSP
yNwWJDmMdfs8i+3/4ADCboFbu1coQUfTm41DKQnaxykucJU/wJFWBdNfEddsIA7Q3m2N9O
Um7IuFiAHMo1Sh3hLvdpmnxr9+3rjQ06vCUlR0Ph4EgE766GOh/DbTSjYyWXJwusA7Bysa
0CPsec+oMB5MqslTMWULwfEvgRgVO2C0JmICMfs0JNYqj3eV9ZEPluy5cXWDcoQA==
Mime-Version: 1.0
X-SG-EID:
u001.bI5ZkLckHgS1uX/uew1xm7Gqyoa0IpDnCcvbX7VNNtmy0Jzpvb/P/YQrw
mrhKjdTm2sY/MK8ip+NzFuWXUyX/mbmzB9gum4n
UsZkmxid4KD0J0wdnsKfEPu0YMbykibAzpowa3H
ZE4NxpOKx4F6w/lJjyaaoR961syBZ02MMCo1v6V
VA/oGEqIBjbgci09W10A//KwWpVhH/zCFHoeQhE
Q==
X-Entity-ID: u001.Q1a3p5tGdkqpaJEACGou+w==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Tue, 19 Mar 2024 13:22 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 488122: Concurrent data access violations (MISSING_LOCK)
/websrvr.c: 6243 in respond()

________________________________________________________________________________________________________
*** CID 488122: Concurrent data access violations (MISSING_LOCK)
/websrvr.c: 6243 in respond()
6237 ,session->socket, session->client.protocol, session->client.addr, session->req.physical_path
6238 ,session->req.range_start,session->req.range_end, content_length);
6239 else
6240 lprintf(LOG_INFO,"%04d %s [%s] Sending file: %s (%"PRIdOFF" bytes)"
6241 ,session->socket, session->client.protocol, session->client.addr, session->req.physical_path, content_length);
6242 snt=sock_sendfile(session,session->req.physical_path,session->req.range_start,session->req.range_end);
>>> CID 488122: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "session->send_failed" without holding lock "http_session_t.outbuf_write". Elsewhere, "http_session_t.send_failed" is written to with "http_session_t.outbuf_write" held 1 out of 1 times.
6243 if(!session->send_failed) {
6244 if(session->req.ld!=NULL) {
6245 if(snt<0)
6246 snt=0;
6247 session->req.ld->size=snt;
6248 }

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3DmHtV_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQbYwk4stqvOulAQyfb9Qz7UqXa-2FyYiLNtJQLdPQNB0BbrubVIHVqt8wbwLmHsBUJon6PC9sbncKQ-2BAxsdRHbzS8LHKyt8nQ5XXM7E400tls6CE8QTOmeO-2BbTPMyH95TYfYCuXcmmWIuH-2F2U7WSDFD5czc7Rvy8hX-2BZbhm7O5DgwmQ-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

You can never do just one thing. -- Hardin

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com