Message-ID:

If a fool persists in his folly he shall become wise. -- William Blake

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<65e1db6912cb6_2ac5912c84469bd998983a2@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=3144&group=DOVE-Net.Synchronet_Programming#3144

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <65e1db6912cb6_2ac5912c84469bd998983a2@prd-scan-dashboard-0.mail>
Date: Fri, 1 Mar 2024 13:43:05 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/241475eff Feb 12 2024 GCC 12.2.0
X-FTN-MSGID: 49125.syncprog@1:103/705 2a47d150
X-FTN-CHRS: CP437 2
WhenImported: 20240301054307-0800 41e0
WhenExported: 20240303164636-0800 41e0
ExportedFrom: VERT syncprog 49125
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on git.synchro.net
X-Spam-Level: *
X-Spam-Status: No, score=1.4 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,SENDGRID_REDIR,T_SCC_BODY_TEXT_LINE
autolearn=no autolearn_force=no version=4.0.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=Fsi6LNuLeWS3XInRuzuKgN3rnljzAAAc485XlDV3/nE=;
b=OsMdsb/99i0Gme1zoIkc7e8xXjBHBJNSMDbV966hCUXPl5cfeHRTYhJ/cMkhNWBJysAk
AOaILcbJmn6GhLvTN/9ikVLAbaqt9K4TzBE7CBr9+t7rMApr7Orti+SfBTkwux1w8V0oe/
btGl0mfU14J1JDjacG3+UUW+xWO5g/QX0iOmQBInJCWKrorWAhNQftLAiMu5aUXCWOdsrK
wcQ3FKXJ6bp2dFG5DNO+xpcs4ll/pw5HCd6HgCJ95vmwWiALfyPTqznNsOFjttU0FaBEzh
srPpzXf8ARwnGfn7dghLe8SPfmlpSe+PRwZGE+8rft7Ak85NReejs4D9EeD9HjCQ==
Mime-Version: 1.0
X-SG-EID:
HBOmY/E5MTYb8Mhr7ulQJIaFxcZEWpCD/7YwgOg+H8vkmWoelZfwNHHhgeogCI
a2mgGVAsdU/IAk/44+cD3HsVRoKIR7rp3lrMbhp
uauWEiQWHwfG2ivteZG2M65SnbcpxJZ3sRQPOSZ
je6JfKJnORqWREbB9xeVEyq3fWwoF6ydmrP3Ur8
I+y1NUMjBjkT4VXGY2AD6QpjNT4jJwKt0vw==
X-Entity-ID: S2cgcZKcMUFZg9Mweglhkg==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Fri, 1 Mar 2024 13:43 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 487600: Error handling issues (CHECKED_RETURN)
/sftp.cpp: 1625 in sftp_readdir(sftp_string *, void *)()

________________________________________________________________________________________________________
*** CID 487600: Error handling issues (CHECKED_RETURN)
/sftp.cpp: 1625 in sftp_readdir(sftp_string *, void *)()
1619 free(link);
1620 if (lname == nullptr) {
1621 sftp_fattr_free(attr);
1622 return sftps_send_error(sbbs->sftp_state, SSH_FX_FAILURE, "Longname allocation failure");
1623 }
1624 vpath = getfname(tmppath);
>>> CID 487600: Error handling issues (CHECKED_RETURN)
>>> Calling "add_name" without checking return value (as is done elsewhere 4 out of 5 times).
1625 fn.add_name(strdup(vpath), lname, attr);
1626 }
1627 }
1628 else {
1629 if (dd->info.filebase.lib == -1) {
1630 // /files/ (ie: list of libs)

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3D_Mv9_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQZAvea4qFQBhPrjKB4cHy2kAbmKz1-2F0ttbXdmTqhC-2BEq7-2Bvgywi6EN0yh9ZWlpucVXNfv4OAgSDch06A-2FyZfKQuykxNA3ygHnLLNJZ-2FPbpNGcgiztSzdmC0nW0gtMv3miUCmrLhEqR-2FOP8z9BsqWg6i-2B8KyEK4CuE0E7PMo9TUvnw-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com