Message-ID:

I'm not denyin' the women are foolish: God Almighty made 'em to match the men. -- George Eliot

dovenet / Synchronet Programming / Add initial support for SFTP

Add initial support for SFTP

<65DD17F7.49081.syncprog@vert.synchro.net>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=3100&group=DOVE-Net.Synchronet_Programming#3100

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: rob.swindell@VERT (Rob Swindell)
To: GitLab note in main/sbbs
Subject: Add initial support for SFTP
Message-ID: <65DD17F7.49081.syncprog@vert.synchro.net>
Date: Mon, 26 Feb 2024 15:00:07 -0800
X-Comment-To: GitLab note in main/sbbs
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/3000ece51 Feb 24 2024 GCC 12.2.0
X-FTN-MSGID: 49081.syncprog@1:103/705 2a430db0
X-FTN-CHRS: CP437 2
WhenImported: 20240226150007-0800 41e0
WhenExported: 20240303164636-0800 41e0
ExportedFrom: VERT syncprog 49081
Content-Type: text/plain; charset=IBM437
Content-Transfer-Encoding: 8bit

by: Rob Swindell - Mon, 26 Feb 2024 23:00 UTC

https://gitlab.synchro.net/main/sbbs/-/merge_requests/415#note_4970

It looks like in the code now, shell_login defaults to false and is only set to true under a specific SSH-login. Is there some other place shell_ogin is being set to true now for non-SSH logins?

I was thinking there could be something like `enum ssh_session_type { sshe_none, ssh_shell, ssh_ftp } ssh_login;`

And then `if (ssh_login != ssh_ftp)` (in the subsequent now-conditional blocks that are to only execute for non-SFTP session) seems clearer to me.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

Subject	Author
Add initial support for SFTP	Rob Swindell