RetroBBS - DOVE-Net.Synchronet_Programming

src/xpdev/link_list.c

<65CE7EF9.48862.syncprog@vert.synchro.net>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=2881&group=DOVE-Net.Synchronet_Programming#2881

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: deuc?@VERT (Deuc?)
To: Git commit to main/sbbs/master
Subject: src/xpdev/link_list.c
Message-ID: <65CE7EF9.48862.syncprog@vert.synchro.net>
Date: Thu, 15 Feb 2024 13:15:37 -0800
X-Comment-To: Git commit to main/sbbs/master
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/6326f6d0d Feb 13 2024 GCC 12.2.0
X-FTN-MSGID: 48862.syncprog@1:103/705 2a3473d7
X-FTN-CHRS: CP437 2
WhenImported: 20240215131537-0800 41e0
WhenExported: 20240215154816-0800 41e0
ExportedFrom: VERT syncprog 48862
Content-Type: text/plain; charset=IBM437
Content-Transfer-Encoding: 8bit

by: Deuc? - Thu, 15 Feb 2024 21:15 UTC

https://gitlab.synchro.net/main/sbbs/-/commit/44afa1b3c4231a1d291fcfa7
Modified Files:
src/xpdev/link_list.c
Log Message:
Don't hold a mutex while it's destroyed.

Found by Coverity.
If there's actually another thread using the list when the refcount
hits zero, you're going to have a bad time regardless of the lock.

Coverity has been pointing this out for a while, but we've been
ignoring it as a false positive.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

You will be a winner today. Pick a fight with a four-year-old.

dovenet / Synchronet Programming / src/xpdev/link_list.c

Subject	Author
src/xpdev/link_list.c	Deuc?