Message-ID:

After all, it is only the mediocre who are always at their best. -- Jean Giraudoux

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<65ccc2d164808_1acc3c2ca6c8ee39a0620c0@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=2872&group=DOVE-Net.Synchronet_Programming#2872

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <65ccc2d164808_1acc3c2ca6c8ee39a0620c0@prd-scan-dashboard-0.mail>
Date: Wed, 14 Feb 2024 13:40:33 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/241475eff Feb 12 2024 GCC 12.2.0
X-FTN-MSGID: 48853.syncprog@1:103/705 2a32b7a8
X-FTN-CHRS: CP437 2
WhenImported: 20240214054035-0800 41e0
WhenExported: 20240214094819-0800 41e0
ExportedFrom: VERT syncprog 48853
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on git.synchro.net
X-Spam-Level: *
X-Spam-Status: No, score=1.4 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,SENDGRID_REDIR,T_SCC_BODY_TEXT_LINE
autolearn=no autolearn_force=no version=4.0.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=9tbwxY7NFHcwqIQ8Ays/XBD7CtUoyuir58S9wtgDZfo=;
b=uNktDI2FTiDdmyEBZTx6OqydK5b29IgFEZTUxd7yMoK11vqKzen2UPvn6Zyw4eDdsIck
LJeFgkRmdIqY8S9WWcDCcy6ZPILRcuhbqvtASwkg5T/DOrLamHC0PivU0w5/9jaqKA32zr
ojTArpyLZSo3xEepJfaPzOjVAidXtlsxeCLF9JQF16Y4IJu6wZnhSfZdl4hAuv46v4Qdit
2ty4NhcmE1EuUvqmoa78YfXCRqUzkLyUmG47IqQgXEg5itXNZQPhGTp8AYKL9uyY6TByAf
r22g196578e7lTX61XAUg0poMoHz29+kLzl/ZCipdzaep+9dc3b6iPBmoFVzYkYQ==
Mime-Version: 1.0
X-SG-EID:
HBOmY/E5MTYb8Mhr7ulQJIaFxcZEWpCD/7YwgOg+H8sV5zd7bycAANNg59/fNB
n/YYzop3yHIBVeSHpdQ1tejDVTAvbj6jTCL6nRY
4Eumw7L4gp+Q9nowrQmrgdt6e7PEikAeOZD9Xow
10LrDqI7gpIE5fpFXcnyH8p5e69ExBiHtpiifVt
lvdQ1PC4OBc9IbfKoipEEYAiTw6A+OfsVwQ==
X-Entity-ID: S2cgcZKcMUFZg9Mweglhkg==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Wed, 14 Feb 2024 13:40 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 486477: Error handling issues (CHECKED_RETURN)
/writemsg.cpp: 416 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()

________________________________________________________________________________________________________
*** CID 486477: Error handling issues (CHECKED_RETURN)
/writemsg.cpp: 416 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()
410 free(buf);
411 return(false);
412 }
413 if(!i && linesquoted)
414 break;
415 if(!i || quote[0]==all_key()) { /* Quote all */
>>> CID 486477: Error handling issues (CHECKED_RETURN)
>>> Calling "fseek(stream, l, 0)" without checking return value. This library function may fail and return an error code.
416 fseek(stream,l,SEEK_SET);
417 while(!feof(stream) && !ferror(stream)) {
418 if(!fgets(str,sizeof(str),stream))
419 break;
420 quotestr(str);
421 SAFEPRINTF2(tmp,quote_fmt,cols-4,str);

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4E6fW2ok94RcmG1J20ETIf4-3D2gqt_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDyBxF-2BuedSB2oLaNTy6psp3Cor4F0rz-2B4SwaIkEVyFE7FwRjEukPY43bM1L1Hi7YMYgyrb0V1krz3N47RLZR8GIqMuk2Z3RqE2OO4o9y0KvmmLDJLp5jbtMBebo-2FmfheUw1RP41SRg-2FK16Oi1OoUubPmh6iPKTPVX1V81t13b6sA-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com