RetroBBS - DOVE-Net.Synchronet_Programming - New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<65c38a31697ff_13e7e52ca6c8ee39a062072@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=2706&group=DOVE-Net.Synchronet_Programming#2706

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <65c38a31697ff_13e7e52ca6c8ee39a062072@prd-scan-dashboard-0.mail>
Date: Wed, 7 Feb 2024 13:48:34 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/76cda3434 Feb 2 2024 GCC 12.2.0
X-FTN-MSGID: 48687.syncprog@1:103/705 2a297e62
X-FTN-CHRS: CP437 2
WhenImported: 20240207054835-0800 41e0
WhenExported: 20240207094810-0800 41e0
ExportedFrom: VERT syncprog 48687
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on git.synchro.net
X-Spam-Level:
X-Spam-Status: No, score=1.0 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,SENDGRID_REDIR,T_SCC_BODY_TEXT_LINE
autolearn=no autolearn_force=no version=4.0.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=GA0dz7VP9nnk52FSsIxu9AMIc7am3Q5lT7lp+2XyV+I=;
b=XVEfKuLklLKBdL7+hAOOHgbFFrQkpIdnJwTECXf3b6LmlOVXs9C/o7KVo6bfQ+KfFDVA
VEKw0nlKtJrFSxgAEGOgixR4N1iqT9uO3qBKkqFAfdpKUrdkJkSGpiacPoVdwL3rvQBaYJ
3h7nx8Ez7aWZFrkjVChXENdKk1jKy8uE1ayjO5FrYVDQTau+9SBt6HJpdL5owVVIov9Paf
qzwfI7P4eGGKcpeZcNMc1XbY1SfCS1ngDHPbf2pVCM5fsnvoKSxPg+hchDwA5WVssHqf/H
7G3GMl5vEU2kGllTmOLluQ92VKJpoeeRace6SLRteD8fhdI5PxwUiTY3Tf2Vy0Vw==
Mime-Version: 1.0
X-SG-EID:
HBOmY/E5MTYb8Mhr7ulQJIaFxcZEWpCD/7YwgOg+H8ueTiMtIUzp6UWI9xBjd+
20yEs5DeXcbcubHftdCElNlOIn8blEDrwsXNZz+
GHU5lYfkyB+dk02vZoXoseQVQMU643wukciaev/
Av5tmZRZW9HIqOs8siriBzUq0Gq5e9U+AMR4Oy7
fDUCrdaHKcb7FQ1dAkMz391BWqQonfT8mGA==
X-Entity-ID: S2cgcZKcMUFZg9Mweglhkg==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Wed, 7 Feb 2024 13:48 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 486181: (RESOURCE_LEAK)
/js_bbs.cpp: 1730 in js_expand_atcodes(JSContext *, unsigned int, unsigned long *)()
/js_bbs.cpp: 1732 in js_expand_atcodes(JSContext *, unsigned int, unsigned long *)()

________________________________________________________________________________________________________
*** CID 486181: (RESOURCE_LEAK)
/js_bbs.cpp: 1730 in js_expand_atcodes(JSContext *, unsigned int, unsigned long *)()
1724 if (instr == NULL)
1725 return JS_FALSE;
1726
1727 if(JSVAL_IS_OBJECT(argv[1]) && !JSVAL_IS_NULL(argv[1])) {
1728 JSObject* hdrobj;
1729 if((hdrobj = JSVAL_TO_OBJECT(argv[1])) == NULL)
>>> CID 486181: (RESOURCE_LEAK)
>>> Variable "instr" going out of scope leaks the storage it points to.
1730 return JS_FALSE;
1731 if(!js_GetMsgHeaderObjectPrivates(cx, hdrobj, /* smb_t: */NULL, &msg, /* post: */NULL))
1732 return JS_FALSE;
1733 }
1734
1735 rc = JS_SUSPENDREQUEST(cx);
/js_bbs.cpp: 1732 in js_expand_atcodes(JSContext *, unsigned int, unsigned long *)()
1726
1727 if(JSVAL_IS_OBJECT(argv[1]) && !JSVAL_IS_NULL(argv[1])) {
1728 JSObject* hdrobj;
1729 if((hdrobj = JSVAL_TO_OBJECT(argv[1])) == NULL)
1730 return JS_FALSE;
1731 if(!js_GetMsgHeaderObjectPrivates(cx, hdrobj, /* smb_t: */NULL, &msg, /* post: */NULL))
>>> CID 486181: (RESOURCE_LEAK)
>>> Variable "instr" going out of scope leaks the storage it points to.
1732 return JS_FALSE;
1733 }
1734
1735 rc = JS_SUSPENDREQUEST(cx);
1736 sbbs->expand_atcodes(instr, result, sizeof result, msg);
1737 free(instr);

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4E6fW2ok94RcmG1J20ETIf4-3DmylI_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDXJXQdHoPdhvgvF0Vb847O95f-2F78EIoUagepOVq0LGxVFLDoLOCCiMG-2Fo4JxZOKwjHbMnoOXJKKkCjtFcCkE7VRLhxJ-2FNLJW4jwAN0Jl-2F3no6moASPMez-2F6bxuKm8Qy55QwIHngsrpIdU6tJlGz6f2tQot6J2A4fn-2FWICSVomHTA-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

PUNK ROCK!! DISCO DUCK!! BIRTH CONTROL!!

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com