Message-ID:

<Addi> Alter.net seems to have replaced one of its router with a zucchini.

dovenet / Synchronet Programming / New Defects reported by Coverity Scan for Synchronet

New Defects reported by Coverity Scan for Synchronet

<65c0e52a38264_11e68c2ca6c8ee39a06205e@prd-scan-dashboard-0.mail>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=2574&group=DOVE-Net.Synchronet_Programming#2574

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: scan-admin@coverity.com@VERT (scan-admin@coverity.com)
To: cov-scan@synchro.net
Subject: New Defects reported by Coverity Scan for Synchronet
Message-ID: <65c0e52a38264_11e68c2ca6c8ee39a06205e@prd-scan-dashboard-0.mail>
Date: Mon, 5 Feb 2024 13:39:54 +0000
X-Comment-To: cov-scan@synchro.net
Path: rocksolidbbs.com!not-for-mail
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/76cda3434 Feb 2 2024 GCC 12.2.0
X-FTN-MSGID: 48555.syncprog@1:103/705 2a26d8d6
X-FTN-CHRS: CP437 2
WhenImported: 20240205053955-0800 41e0
WhenExported: 20240205094817-0800 41e0
ExportedFrom: VERT syncprog 48555
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on git.synchro.net
X-Spam-Level:
X-Spam-Status: No, score=1.0 required=4.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,NO_RELAYS,SENDGRID_REDIR,T_SCC_BODY_TEXT_LINE
autolearn=no autolearn_force=no version=4.0.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coverity.com;
h=from:subject:mime-version:to:content-type:content-transfer-encoding:
cc:content-type:from:subject:to;
s=sc; bh=OQHcJdFfCr73awy2TjS6lSjvR5vMETBeC88ujPDKu+s=;
b=DJ3Rpgv5HA4HS7DyMhWkbBAUi+Q9brQC8J7cXZ7hOGHMgaodkBcwvqdWqqPcNDFFpwZ1
RuCpgtv+9pdkAcXn9BTqNu8uWIOWVqpJ02/zeRkJK/s0aGcVHJ+GkJDGUmXQ9Abmmntu03
2AxE25gsHIiESqcNx/DkVgsDyCuJVPnnljPWOdMSmsBvOhvteZh0PXtb4uk0wG84UDA8u5
ggaKlH6j0O+7UbbLvj/yHpfd1p7W/Fb2bzXRNnSbFiNbQVEXSNdjR8N19fUIn+OznHm1J4
EMYxFA61VTU41Qhcd951wmz+UcmcRQYuxsQAvuMMXM1AAG6HVUC/0GfY0C5Roqpg==
Mime-Version: 1.0
X-SG-EID:
HBOmY/E5MTYb8Mhr7ulQJIaFxcZEWpCD/7YwgOg+H8s4jrLLV2Ngh7chCeC+R5
6F/cRh68AfC8gD2xFG8Q17bp4CA5CZ0JTmqBZeP
rmiiK1v59bdPegN3cCGoGoqZz4aXb+0TVV01kBs
/e0m2OLybmb03wOAbG9DQsIWuuCMjUGnsW1P62d
BVEpMOuedN7tWiC26idU0auhCscg1g1Ns6A==
X-Entity-ID: S2cgcZKcMUFZg9Mweglhkg==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

by: scan-admin@coverity. - Mon, 5 Feb 2024 13:39 UTC

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 483249: Error handling issues (CHECKED_RETURN)
/main.cpp: 3570 in sbbs_t::init()()

________________________________________________________________________________________________________
*** CID 483249: Error handling issues (CHECKED_RETURN)
/main.cpp: 3570 in sbbs_t::init()()
3564 thisnode.misc&=(NODE_EVENT|NODE_LOCK|NODE_RRUN);
3565 criterrs=thisnode.errors;
3566 putnodedat(cfg.node_num,&thisnode);
3567
3568 // remove any pending node messages
3569 safe_snprintf(str, sizeof(str), "%smsgs/n%3.3u.msg",cfg.data_dir,cfg.node_num);
>>> CID 483249: Error handling issues (CHECKED_RETURN)
>>> Calling "remove(str)" without checking return value. This library function may fail and return an error code.
3570 remove(str);
3571 // Delete any stale temporary files (with potentially sensitive content)
3572 delfiles(cfg.temp_dir,ALLFILES);
3573 safe_snprintf(str, sizeof(str), "%sMSGTMP", cfg.node_dir);
3574 removecase(str);
3575 safe_snprintf(str, sizeof(str), "%sQUOTES.TXT", cfg.node_dir);

________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4E6fW2ok94RcmG1J20ETIf4-3DuxM4_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDlWnKXqUo4ko-2BswZDnU0KThZlBPhv1kFyIVU6rRp9K48otOTA5WQm5qg8o-2FY8FDqYkPfgDhKOyoUIQMv1mPwAY7yKStOAqjn6xloHvMgh0mRG0DJXpuxyIOkTyi2gGZzdoTshBDw9gCNjiMqTW3IeGxtntX-2B4oBRMrCvut8dx1Kg-3D-3D

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Subject	Author
New Defects reported by Coverity Scan for Synchronet	scan-admin@coverity.com