Message-ID:

We don't need no education, we don't need no thought control. -- Pink Floyd

dovenet / Synchronet Programming / src/sbbs3/writemsg.cpp

src/sbbs3/writemsg.cpp

<6584A255.48221.syncprog@vert.synchro.net>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=2219&group=DOVE-Net.Synchronet_Programming#2219

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: rob.swindell.(on.windows.11)@VERT (Rob Swindell (on Windows 11))
To: Git commit to main/sbbs/master
Subject: src/sbbs3/writemsg.cpp
Message-ID: <6584A255.48221.syncprog@vert.synchro.net>
Date: Thu, 21 Dec 2023 12:38:45 -0800
X-Comment-To: Git commit to main/sbbs/master
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/de72961d5 Dec 20 2023 GCC 12.2.0
X-FTN-MSGID: 48221.syncprog@1:103/705 29ea94b2
X-FTN-CHRS: CP437 2
WhenImported: 20231221123845-0800 41e0
WhenExported: 20231221141331-0800 41e0
ExportedFrom: VERT syncprog 48221
Content-Type: text/plain; charset=IBM437
Content-Transfer-Encoding: 8bit

by: Rob Swindell (on Win - Thu, 21 Dec 2023 20:38 UTC

https://gitlab.synchro.net/main/sbbs/-/commit/daf8fa55aa08b39bf8b4fc6e
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
Fix internal line editor buffer overflow (heap corruption)

.... wasn't accounting for length of the 'top' buffer (when supplied).

Also, for raw input mode:
- flush the input buffer (stray LF) before accepting input
- turn off raw input mode if run out of bytes (max lines/length reached)

I was investigating the reported error by Nelgin:
!ERROR in writemsg.cpp line 1214 (msgeditor) checking
"max lines (20) exceeded" access=46
which I was unable to reproduce, when I encountered the issues addressed
in this commit.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

Subject	Author
src/sbbs3/writemsg.cpp	Rob Swindell (on Windows 11)