RetroBBS - DOVE-Net.Synchronet_Programming

src/xpdev/ini_file.c

<644EB58D.47017.syncprog@vert.synchro.net>

https://www.rocksolidbbs.com/dovenet/article-flat.php?id=1018&group=DOVE-Net.Synchronet_Programming#1018

copy link Newsgroups: DOVE-Net.Synchronet_Programming

From: rob.swindell.(on.chromeos)@VERT (Rob Swindell (on ChromeOS))
To: Git commit to main/sbbs/master
Subject: src/xpdev/ini_file.c
Message-ID: <644EB58D.47017.syncprog@vert.synchro.net>
Date: Sun, 30 Apr 2023 11:38:05 -0700
X-Comment-To: Git commit to main/sbbs/master
Path: rocksolidbbs.com!not-for-mail
Organization: Vertrauen
Newsgroups: DOVE-Net.Synchronet_Programming
X-FTN-PID: Synchronet 3.20a-Linux master/16a9cd5d2 Apr 15 2023 GCC 12.2.0
X-FTN-MSGID: 47017.syncprog@1:103/705 28b4a336
X-FTN-CHRS: CP437 2
WhenImported: 20230430113805-0700 c1e0
WhenExported: 20230430152647-0700 c1e0
ExportedFrom: VERT syncprog 47017
Content-Type: text/plain; charset=IBM437
Content-Transfer-Encoding: 8bit

by: Rob Swindell (on Chr - Sun, 30 Apr 2023 18:38 UTC

https://gitlab.synchro.net/main/sbbs/-/commit/b9e5efacac9390d5af47c56e
Modified Files:
src/xpdev/ini_file.c
Log Message:
Fix memory leak in iniFreeParsedSections(), wasn't freeing the list member

The 'list' member was allocated by iniParseSections() but never freed.

Caught be Nelgin's recent valgrind report, e.g.:

==2725235== 56 bytes in 1 blocks are indirectly lost in loss record 82 of 191
==2725235== at 0x484DCD3: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==2725235== by 0x4FA351C: strListAnnex (in /home/bbs/sbbs/repo/src/sbbs3/gcc.linux.x64.lib.release/libsbbs.so)
==2725235== by 0x4F9ADDE: iniParseSections (in /home/bbs/sbbs/repo/src/sbbs3/gcc.linux.x64.lib.release/libsbbs.so)
==2725235== by 0x49F1F0A: read_chat_cfg (in /home/bbs/sbbs/repo/src/sbbs3/gcc.linux.x64.lib.release/libsbbs.so)
==2725235== by 0x49E8BF1: load_cfg (in /home/bbs/sbbs/repo/src/sbbs3/gcc.linux.x64.lib.release/libsbbs.so)
==2725235== by 0x5C14C75: ftp_server (in /home/bbs/sbbs/repo/src/sbbs3/gcc.linux.x64.lib.release/libftpsrvr.so)
==2725235== by 0x5D5AB42: start_thread (pthread_create.c:442)
==2725235== by 0x5DEBBB3: clone (clone.S:100)

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

I stick my neck out for nobody. -- Humphrey Bogart, "Casablanca"

dovenet / Synchronet Programming / src/xpdev/ini_file.c

dovenet / Synchronet Programming / src/xpdev/ini_file.c

Subject	Author
src/xpdev/ini_file.c	Rob Swindell (on ChromeOS)