On 05/08/2023 23:07, Dirk Fieldhouse wrote:

> Seems like most of GitHub is working in 2.53.17 with webcomponents and custom_elements enabled (non-default settings), and no PaleFill or user scripting, but no doubt the children will find a new way of screwing the whole thing up.

And indeed dynamic pop-up menus now fail, eg the comment ... menu shows
only Quote Reply and a whirling wait image replaced by "Something went
wrong" where Edit, Hide, etc, should be shown.

The error is in this code:
<https://github.githubassets.com/assets/app/assets/modules/github/virtual-listbox-focus-state.ts>

TypeError: t.values is not a function virtual-listbox-focus-state.ts:20:46
VirtualListboxFocusState virtual-listbox-focus-state.ts:20:46
connectedCallback project-picker-element.ts:59:20
connectedCallback core.js:44:32
CatalystDelegate/e.prototype.connectedCallback core.js:12:21
f register.js:12:30
CatalystDelegate core.js:33:8
S controller.js:9:4
f
https://github.githubassets.com/assets/chunk-app_components_sidebar_project-picker-element_ts-18536df0171f.js:1:3450
[73209] project-picker-element.ts:33:6
s bootstrap:19:31
s self-hosted:1032:17

Failing TS code:

export default class VirtualListboxFocusState<V> {
constructor(rootElement: VirtualListElement<V>) {
this.#rootElement = rootElement
this.#itemsArray = Array.from(rootElement.values()) /* here */
this.#onReleaseFocus = this.releaseFocus.bind(this)
this.#rootElement.addEventListener('focus', () => {

Resulting transpiled JS:
/* snip */
constructor(t) {
/* snip */
l(this, c, t),
l(this, d, Array.from(t.values())),
l(this, b, this.releaseFocus.bind(this)),
a(this, c).addEventListener('focus', () = > {

Whatever rootElement aka t is doesn't have a .values() method.

/df

--
London
UK

Also this fragment found in two places

m=class extends
Event{oldState;newState;constructor(e,{oldState:t="",newState:n="",...o}={}

causes "SyntaxError: missing : after property id" and breaks the actual
code display. "You had one job..."

/df

--
London
UK

On 2023-10-04, Dirk Fieldhouse wrote:

> Also this fragment found in two places
>
> m=class extends
> Event{oldState;newState;constructor(e,{oldState:t="",newState:n="",...o}={}
>
>
> causes "SyntaxError: missing : after property id" and breaks the
> actual code display. "You had one job..."
>
> /df

Is this the code display - showing file content - that used to work
without javascript until recently?

That, to me, dealt a huge blow to the usefulness of github here. It used
to be possible to look at several files and navigate around the file
tree without javascript...

--
Nuno Silva

On 04/10/2023 09:54, Nuno Silva wrote:
> On 2023-10-04, Dirk Fieldhouse wrote:
>
>> Also this fragment found in two places
>>...
>> causes "SyntaxError: missing : after property id" and breaks the
>> actual code display. "You had one job..."
>
> Is this the code display - showing file content - that used to work
> without javascript until recently?

Yes.

> That, to me, dealt a huge blow to the usefulness of github here. It used
> to be possible to look at several files and navigate around the file
> tree without javascript...

Codeberg FTW. But I can't force other people's GH projects to leave.

/df

--
London
UK

Dirk Fieldhouse wrote:

>> That, to me, dealt a huge blow to the usefulness of github here. It used
>> to be possible to look at several files and navigate around the file
>> tree without javascript...
>
> Codeberg FTW. But I can't force other people's GH projects to leave.

I'm seeing a more serious problem, from just a few days ago

Browsing to:

https://github.com/skullanbones/mpeg2ts

The home page works, I can see the files tree and contents of the
README.md file.

BUT, if I click on LICENSE.md, I just get a (mostly) blank screen.

Is that the same issue?

On 06/10/2023 19:25, gerry 666uk wrote:
>...>
> https://github.com/skullanbones/mpeg2ts
>
> The home page works, I can see the files tree and contents of the
> README.md file.
>
> BUT, if I click on LICENSE.md, I just get a (mostly) blank screen.
>
> Is that the same issue?

It's the problem that Nuno mentioned. But ... dut-dut-daaah ... GH seems
to have secretly reintroduced non-JS code browsing **just now**. Try
again (WFM).

To be fair, this was promised after the code browser pages were
upgraded/broken but I'd just about lost hope of the promise being
fulfilled. Ofc it could just be a roll-out accident and break again in a
few days. The editor doesn't work without JS, though, which is still
broken compared with the old code browser.

/df

--
London
UK

Dirk Fieldhouse wrote:

> It's the problem that Nuno mentioned. But ... dut-dut-daaah ... GH seems
> to have secretly reintroduced non-JS code browsing **just now**. Try
> again (WFM).

I tested again, the day after this post, and it was still broken for me,
not able to view a single file, but right now, 12 Oct 2023, it has
started working again, I can see the tree, and view the files.

On 12/10/2023 19:08, gerry 666uk wrote:
> ...>
> I tested again, the day after this post, and it was still broken for me,
> not able to view a single file, but right now, 12 Oct 2023, it has
> started working again, I can see the tree, and view the files.

It's not (yet?) working for not-logged-in browsing.

/df

--
London
UK

Dirk Fieldhouse wrote:
> On 12/10/2023 19:08, gerry 666uk wrote:
>> ...>
>> I tested again, the day after this post, and it was still broken for
>> me, not able to view a single file, but right now, 12 Oct 2023, it has
>> started working again, I can see the tree, and view the files.
>
> It's not (yet?) working for not-logged-in browsing.

Ah ok. I've just checked and I'm shown as being logged in, so maybe
that's why it's working.